Am I misunderstanding `HttpClient#config`? I expec...

# ktor

[octylFractal]

Am I misunderstanding HttpClient#config? I expected that it would be equivalent to adding the given block to the end of the original config block, but it instead it overwrites it

[Deactivated User]

what are you trying to do?

[Deactivated User]

Have you noticed the HttpClientConfig#engine?

[octylFractal]

I used install to add some features/interceptors, and I wanted to create another copy with those same features + additional custom interceptors

[Deactivated User]

aha

[octylFractal]

it doesn't work since the pipelines aren't copied over, but I don't know if that's intended or a bug

[Deactivated User]

indeed, it seems that there is a bug, since the documentation states that it should copy the configuration

[Deactivated User]

fun config(block: HttpClientConfig<*>.() -> Unit): HttpClient = HttpClient(
        engine, useDefaultTransformers, HttpClientConfig<HttpClientEngineConfig>().apply(block)
    )

[Deactivated User]

should probably be:

fun config(block: HttpClientConfig<*>.() -> Unit): HttpClient = HttpClient(
        engine, useDefaultTransformers, config.clone().apply(block)
    )

[octylFractal]

alright, should I file an issue / make a PR for this?

[Deactivated User]

if you can, that would be nice, yeah 🙂 if you make a PR, please ensure to add a test that verifies the new behaviour

[octylFractal]

I can do that, thanks for confirming the bug