Someone on Vert.x Gitter channel suggested replaci...

# ktor

[dave08]

Someone on Vert.x Gitter channel suggested replacing Netty's EventGroups w/ Vert.x's to implement a Vert.x bridge with Ktor, see:
https://github.com/ktorio/ktor/blob/d1e3a495cfe26c32aa5af4b110f6af9ddbd329e4/ktor-server/ktor-server-netty/src/io/ktor/server/netty/NettyApplicationEngine.kt#L51
https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/http/impl/HttpServerImpl.java#L247

Then I could expose the Vert.x instance to the app somehow to use it to create Vert.x components like async dbs etc... is it possible that it's that easy, or are there possible pitfalls in this approach?

[Deactivated User]

Nice. Not totally sure. But what’s the problem on having a few extra threads? (maybe I’m missing something)

[dave08]

Maybe nothing, I'm not familiar of all the internals, so I'm being careful, in the issue @orangy said "I think vert.x host for ktor is the way to go here. We will still need HTTP message processing and all the related stuff." and "I was thinking about hosting ktor app as a verticle, like a servlet in an app container"...?

[dave08]

I mean in https://github.com/ktorio/ktor/issues/286

[Deactivated User]

If you want, I can try to do a prototype of an application engine using vertx and a small stress test and see what happens. It should be enough to see if there would be additional issues or it works fine.

[orangy]

I don’t know if they are compatible, or if it will have any unintended consequences. I’d really just make a vert.x engine, if you need interoperation there. It shouldn’t be that hard, I think.

[dave08]

There's tons of interfaces to implement, no? Would we have to make a new engine or just reuse part of Netty?

[dave08]

I don't know if Vert.x exposes everything, but as far as understood there's a few places that can just be casted to expose internals

[Deactivated User]

Not that much interfaces: https://ktor.io/advanced/engines.html

[dave08]

Like:
https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/impl/ContextInternal.java
https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/impl/ContextImpl.java
https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/Context.java

[dave08]

The Netty implementation is all this: https://github.com/ktorio/ktor/tree/d1e3a495cfe26c32aa5af4b110f6af9ddbd329e4/ktor-server/ktor-server-netty/src/io/ktor/server/netty?

[Deactivated User]

https://github.com/ktorio/ktor/tree/d1e3a495cfe26c32aa5af4b110f6af9ddbd329e4/ktor-server/ktor-server-jetty/src/io/ktor/server/jetty

[Deactivated User]

jetty

[orangy]

if you initially target only http1.1, that should be relatively small

[dave08]

That's the difference w/ Jetty implementation? Why is it so much smaller?

[dave08]

So all the requests/responses would also be delegated to vert.x core handling them, and not the underlying Netty? @orangy

[dave08]

Like this api: https://vertx.io/docs/vertx-core/kotlin/#_writing_http_servers_and_clients

[orangy]

I don’t really know vert.x that good, sorry…

[dave08]

Np, I just wanted to clarify what has to be done...

[orangy]

I think @julienviet previously said he is ready to consult anyone who would implement ktor on top of vert.x

[dave08]

Right, but he doesn't know the Ktor side 🙂 ...

[dave08]

So, I'm just trying to figure out how to put things together...

[orangy]

I think you just need to start 🙂

[dave08]

True, I'll maybe give it a shot next week. It would help to know what's the minimum that needs to be implemented.. is Jetty the example to take from?

[orangy]

Minimum is engine, call, request & response, I think

[kenkyee]

Might want to look at the Spring vert.x integration...Spring is essentially hosting vert.x and it sounds like you're trying to use ktor to do the same thing?