Would people be interested in a session storage im...
# ktorm
mp
05/01/2018, 4:26 PMWould people be interested in a session storage implementation backed by redis? I needed it for a project, but I don't mind open sourcing it. (Unlike the example in https://ktor.io/features/sessions.html, it has tests, and is non-blocking.)
o
orangy
05/01/2018, 4:38 PM
I think @Deactivated User just implemented one yesterday… Please talk and review each other’s code and find the best possible solution to merge 🙂
d
Deactivated User
05/01/2018, 4:49 PMhttps://github.com/ktorio/ktor/compare/redis-cio still requires review, but you can check it already. Let me know if you opensource your code to check if we can merge efforts :) and of course comments/suggestions are welcome!
m
mp
05/01/2018, 4:50 PMGreat, I’ll check it out!
mp
05/01/2018, 9:51 PMThe session part is pretty similar, but mine uses the lettuce.io redis client. I can imagine that once the redis client in that branch is done, it will be simpler to have something with fewer dependencies, but for now using a battle-tested redis client suits my needs better. Can't compete with a built-in solution... I'm happy to package up my stuff if people will find it useful today but probably by a month from now the built-in one will be ready I imagine
d
Deactivated User
05/02/2018, 8:57 AMSure. Makes sense. The redis protocol is pretty simple and the session only uses a small subset of redis. I have done some stress tests already and should behave well under pressure. But obviously the more time, the more tested. The idea of providing a custom CIO client is that it can work in the future with Kotlin Native too. Also I think may make sense to allow to select a redis implementation like happens with the server and the http client so people can choose. So if you opensource your client, maybe we can provide both the CIO and the lettuce.io clients 🙂
👍 1
m
mp
05/02/2018, 12:16 PMGood point. it wouldn't need to be a very sophisticated abstraction layer -- just a couple of commands
mp
05/02/2018, 12:16 PMI'll see if I can carve that out in the next couple of days
👏 1
mp
05/02/2018, 12:29 PMOne thing that would be great is to have a comprehensive test suite applicable to any session storage implementation. It feels silly to write a session storage test that has nothing to do with redis specifically
d
Deactivated User
05/02/2018, 12:29 PMMakes sense
Deactivated User
05/15/2018, 3:05 PMI have updated the redis proposal to allow several engines and have provided one engine using CIO and other using Lettuce. Probably a lot to improve still, so any feedback is welcome 🙂 :
https://github.com/ktorio/ktor/compare/redis-cio
m
mp
05/16/2018, 4:56 PMGreat, thanks. Sorry for not following up sooner.
6 Views