captures exception and doesn’t respond with 500, let me think… we can’t really send a 500 through a response pipeline in this case, because it could be response pipeline that is broken…
orangy
04/04/2017, 11:22 AM
Also, headers could have been already sent…
s
spand
04/04/2017, 11:40 AM
I would expect it to have no effect on the pipeline so shouldnt it just rethrow the exception ?
spand
04/04/2017, 11:40 AM
Instead of swallowing it ?
o
orangy
04/04/2017, 11:44 AM
Yes, but something should catch it upstream, and there is a place where it is transformed into 500, but it’s sent via response pipeline with all the potential issues. Need a little bit of refactoring, here, on to it today.
s
spand
04/04/2017, 11:55 AM
Sweet. Thanks !
o
orangy
04/04/2017, 12:10 PM
For now I just moved failure processing from CallLogging to default host pipeline and it should be unified from now on – send back 500 on exception. The rest of the issue I’ve described here https://github.com/Kotlin/ktor/issues/82
orangy
04/04/2017, 12:11 PM
pushed, please use local build while we are getting some more changes together for the next version. Hope to release it later this week.