<@UDB0VFBPV> I am trying to run test on Fuel 3x on...

# kotlin-fuel

[itnoles]

@Derk-Jan Karrenbeld I am trying to run test on Fuel 3x on Forge, I get very weird errors from One of deserialize(ByteArray) or deserialize(InputStream) or deserialize(Reader) or deserialize(String) must be implemented

[Derk-Jan Karrenbeld]

Is one of those implemented?

[itnoles]

Yes

[itnoles]

suspend inline fun <reified T : Any> Request.awaitResponseResultObject(noinline deserializer: JSON.() -> DeserializedResult<T>) =
awaitResponseResult(forgeDeserializerOf(deserializer))

[Derk-Jan Karrenbeld]

That looks different

[itnoles]

it supposed to be 🙂

[Derk-Jan Karrenbeld]

https://github.com/kittinunf/fuel/blob/master/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/Deserializable.kt#L35

[itnoles]

it is very tough to see which one occurs 😞

[Derk-Jan Karrenbeld]

You need to either implement Deserializable and overwrite fun deserialize(response: Response): T, or implement ResponseDeserializable and override one of the methods

[Derk-Jan Karrenbeld]

suspend inline fun <reified T : Any> Request.awaitResponseResultObject(noinline deserializer: JSON.() -> DeserializedResult<T>) =
   awaitResponseResult(forgeDeserializerOf(deserializer))

doesn't seem to do either of that?

[itnoles]

https://github.com/kittinunf/fuel/blob/coroutines/fuel-forge/src/main/java/com/github/kittinunf/fuel/forge/FuelForge.kt

[itnoles]

if I commit it with latest changes, would you figure out why?

[itnoles]

https://github.com/kittinunf/fuel/blob/coroutines/fuel-forge/src/test/kotlin/com/github/kittinunf/fuel/forge/FuelForgeTest.kt There

[Derk-Jan Karrenbeld]

Yes, commit and I'll try to figure out what's wrong!

[itnoles]

When I did println(String(response.data)), I see json. Odd. Something must be on deserialize

[Derk-Jan Karrenbeld]

Yeah, that is interesting!

[itnoles]

Now I did override fun deserialize(content: String): T? {
println(content)
return Forge.modelFromJson(content, deserializer).component1()
} I see another json lines.

[itnoles]

I think that compontent1() is null, so it throws

[Derk-Jan Karrenbeld]

yeah, null is not valid

[Derk-Jan Karrenbeld]

I think null = interpreted as no implementation

[itnoles]

T? is Optional

[itnoles]

may be null 🙂

[Derk-Jan Karrenbeld]

can you make it return a "nothing empty object" thing 😛 ?

[Derk-Jan Karrenbeld]

see if that fixes it, for now?

[itnoles]

i did val forge = Forge.modelFromJson(content, deserializer)
println(forge.compontent2()), it comes up as com.github.kittinunf.forge.core.DeserializedResult$Failure@fe7548

[itnoles]

found it com.github.kittinunf.forge.core.PropertyNotFoundException: Property name status is not found

[Derk-Jan Karrenbeld]

so on error you get the INCORRECT error?

[Derk-Jan Karrenbeld]

on deserialization error you get a weird not implemente error

[Derk-Jan Karrenbeld]

that's a bug

[itnoles]

since it is throwing exceptions, it is not catching it and return it as null.

[Derk-Jan Karrenbeld]

got it!

[Derk-Jan Karrenbeld]

sorry 😞

[Derk-Jan Karrenbeld]

probably my fault

[itnoles]

private val httpBinUserDeserializer = { json: JSON ->
::HttpBinUserAgentModel.create
.map(json at "userAgent")
.apply(json at "status")
} Hmm

[itnoles]

I think it is my fault because I switch Triple to Pair.

[itnoles]

{"method":"GET","path":"/user-agent","headers":{"TE":["gzip, deflate; q=0.5"],"content-length":["0"],"Accept":["text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"],"User-Agent":["Java/1.8.0_181"],"Connection":["keep-alive"],"Host":["localhost:54045"]},"reflect":true,"userAgent":"Java/1.8.0_181"} no status