< Derk Jan Karrenbeld> <https github com kittinunf fuel issu kotlinlang #kotlin-fuel

@Derk-Jan Karrenbeld https://github.com/kittinunf/fuel/issues/601#issuecomment-467058763 I am noticed result is actually Triple while the first one is from DefaultRequest, the second one is -1 but third one is actually 410..

🤪 1

Derk-Jan Karrenbeld

02/26/2019, 10:30 AM

so we just dont assign it correctly once

kittinunf

02/26/2019, 10:43 AM

I think it is this line right?

https://github.com/kittinunf/fuel/blob/master/fuel/src/main/kotlin/com/github/kittinunf/fuel/toolbox/HttpClient.kt#L67

I guess we can fix this quickly

Derk-Jan Karrenbeld

02/26/2019, 10:54 AM

Is that the culprit? I don't see any of this code throwing http status exception, so I don't think it's here!

kittinunf

02/26/2019, 11:05 AM

🤔 maybe you are right ….

https://github.com/kittinunf/fuel/pull/603/files#diff-625fd29be82da5d187647ee3ad5d1b2dR90 But I am adding tests to verify the bug

✔️ 1

Derk-Jan Karrenbeld

02/26/2019, 11:07 AM

I think it happens in the process response thing

transform*

When we validate the status code

kittinunf

02/26/2019, 11:15 AM

yeah it is definitely in
SuspendableRequest
file, oh I lied …

man, I think you should have just used my

Result

instead 🤪

🤣 1

Ok this! https://github.com/kittinunf/fuel/pull/603/

there is one thing i learned as a lesson from this bug is that we should test not only the error is not null but also the value inside the error object as well.

Derk-Jan Karrenbeld

02/26/2019, 11:52 AM

This is great!

com.github.[secure].fuel.coroutines.ObjectTest > captureDeserializationException FAILED

java.lang.ClassCastException Caused by: java.lang.ClassCastException

^_^

kittinunf

02/26/2019, 11:55 AM

Oh ???!

Derk-Jan Karrenbeld

02/26/2019, 11:56 AM

(Probably wrapping or error.xxx issue when there is no response?)

kittinunf

02/26/2019, 12:01 PM

ah …. it is this issue https://github.com/kittinunf/Result/issues/47

Derk-Jan Karrenbeld

02/26/2019, 12:03 PM

This is why I wrap in fuelerror everywhere

It could be this, I don't know

you should check the failing test 😛

kittinunf

02/26/2019, 12:05 PM

yeah …. it is painful …

maybe my

Result

is not so good after all 😢

Derk-Jan Karrenbeld

02/26/2019, 12:12 PM

I think it's nice and fine, but now that there is a native result, it's less helpful

kittinunf

02/26/2019, 12:37 PM

OK! I think it should be ready 🙂

@Derk-Jan Karrenbeld when you have time, please send me some love for #603

❤️ 1