https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
Title
# kotlin-fuel
n

Nikky

11/16/2018, 12:15 PM
but each serializer you construct is being constructed with generics and type information for that specific request and expected returned data
d

Derk-Jan Karrenbeld

11/16/2018, 3:01 PM
n

Nikky

11/16/2018, 3:28 PM
sure these are the usual awaitObject function.. but those are not suspended functions
d

Derk-Jan Karrenbeld

11/16/2018, 3:28 PM
Oh haha I'll add it to those as well
n

Nikky

11/16/2018, 3:29 PM
except you cannot unless you want to add dependencies or new modules
gson would have to depend on coroutines
or the other way around
and the same for kotlinx-serialization and jackson and whatever other serialization
d

Derk-Jan Karrenbeld

11/16/2018, 3:30 PM
I'll try to figure out a generic way
"core" actually depends on coroutine (not fuel-coroutine) so it's not that big of a deal
n

Nikky

11/16/2018, 3:31 PM
oh
can we then just more the fuel-coroutines code into core ?
its not that much anyways
but i think the reasoning for separating it into different modules was to avoid dependencies right ?
d

Derk-Jan Karrenbeld

11/16/2018, 3:33 PM
That is probably true. Open an issue?
n

Nikky

11/16/2018, 3:45 PM
will work on that once #512 is merged
❤️ 1
d

Derk-Jan Karrenbeld

11/16/2018, 4:07 PM
If you approve 512, I'll merge it haha
i

igor.wojda

11/17/2018, 12:45 PM
Thanks a lot 👏
d

Derk-Jan Karrenbeld

11/17/2018, 6:10 PM
🙂
2 Views
Powered by