I really like the Result approach and I would like to use it kotlinlang #kotlin-fuel

I really like the Result approach and I would like to use it, if however you all feel that this would not be an advantage I am happy not to do another pr

Lucas

07/02/2018, 11:28 AM

I agree that an API that returns

Result

is a good idea, too. But to avoid confusion, it may be a good idea to refactor the current API, which may cause braking changes.

If that's acceptable I think it may be a good addition.

Mark Gilchrist

07/02/2018, 6:22 PM

would you be happy with the following steps

1) create the functions with names you think they should have

2) mark the current funtions as depicrated with a @ReplaceWith naming the new functions

3) we give people 6 months to change to the new ones

4) add the Result based functions

5) after a period of agreed time we then remove the old ones,

noones code breaks and 🍻

Lucas

07/03/2018, 1:59 PM

Yes, deprecation is a solution.

Have you made a prototype? Maybe we can find a workaround. 🙂

Mark Gilchrist

07/03/2018, 6:33 PM

shall do what I have in a branch and you can look at it before I raise a pr?

I am sure that I will survive if we decide that my idea is not a good one going forward?

https://github.com/kittinunf/Fuel/compare/master...markGilchrist:Add_Result_and_object_Implementations?expand=1

Lucas

07/04/2018, 12:15 PM

It seems good to me. Also after working on PR 373 having an API returning

Result

makes much more sense. I hope it gets accept by the maintainers.

Thank you for proposing this and making the prototype!

Mark Gilchrist

07/04/2018, 1:35 PM

I will give it a much bigger unit test coverage and JDocs before I do that

👍 1

kittinunf

07/07/2018, 7:39 AM

Hey! Sorry I have been logged in this workspack for a while (haha I should be ashamed of myself)