<@U2VPDH0P6> Be aware your code is not safe. I wou...

# intellij

[cedric]

@mingkangpan Be aware your code is not safe. I would rewrite this loop to avoid the !!

[mingkangpan]

cedric: what do you suggest, how?

[cedric]

Since the filter doesn't enable smartcasting, I'd loop manually and test each for null myself, probably with ?.let. This way, you get rid of !!

[cedric]

widget.advertImageList?.forEach { w ->
       w.referenceImageUrl?.let { url ->
            pictureItems.add(PictureSliderAdapter.PictureItemViewModel(url, w.description ?: ""))
        } 
      }

[mingkangpan]

okay thanks

[beholder]

There is filterNotNull method