Hi, i am trying to use `<https://www.npmjs.com/package/@abandonware/noble>` with dukat: ``` i...

# javascript

[uli]

Hi, i am trying to use <https://www.npmjs.com/package/@abandonware/noble> with dukat:

implementation(npm("@abandonware/noble", "1.9.2-7"))

The problem is, that dukat only generates top level functions which can not be resolved at runtime:

@file:Suppress("INTERFACE_WITH_SUPERCLASS", "OVERRIDING_FINAL_MEMBER", "RETURN_TYPE_MISMATCH_ON_OVERRIDE", "CONFLICTING_OVERLOADS", "EXTERNAL_DELEGATION")

import ...

external fun startScanning(callback: (error: Error) -> Unit = definedExternally)

If a add my own type definitions like that things work:

@file:Suppress("INTERFACE_WITH_SUPERCLASS", "OVERRIDING_FINAL_MEMBER", "RETURN_TYPE_MISMATCH_ON_OVERRIDE", "CONFLICTING_OVERLOADS", "EXTERNAL_DELEGATION")

val noble: Noble = js("require('@abandonware/noble')")

external class Noble : events.EventEmitter {
    fun startScanning(callback: (error: Error) -> Unit = definedExternally)

Am I donig something wrong? Are the type script definitons of the package broken? Or is it just dukat?

Btw. the project is compiled with

kotlin {
    target {
        useCommonJs()
        nodejs()

[turansky]

Is there js module annotation in dukat output?

[uli]

I don't think so. Should it be at the head of the file? This is verbatim copied above.

[uli]

Here is the genrated file

index.module_@abandonware_noble.kt

[uli]

I am pretty new to the JS/TS world. But to me it looks like the .d.ts file is already missing module information?
https://github.com/abandonware/noble/blob/master/index.d.ts

[turansky]

Looks like you need add JsModule only in head

[uli]

But dukat will overwrite it the next time. Right?

[turansky]

Yes, but if JsModule resolve the problem, than you can apply WA in custom task and create ticket on dukat

[turansky]

One more option - use latest dukat, possibly bug is already fixed

[uli]

can i tell gradle to use latest dukat?

[uli]

And how would dukat know the module name. I did not find anything in d.ts file

[turansky]

module name = npm module name

[uli]

ah. thanks

[turansky]

index.d.ts - default definitions

[uli]

so maybe the @ is the problem for dukat

[turansky]

Possibly it’s already fixed - https://www.npmjs.com/package/dukat

[turansky]

No - https://github.com/Kotlin/dukat/issues/240

[uli]

Can I tell my gradle build to use a more recent dukat?

[uli]

I mean currently dukat is run automatically from my project's build gradle

[uli]

Ahh, i think i found something
https://github.com/Kotlin/dukat/issues/203#issuecomment-569015843
Will try

[turansky]

If latest dukat won’t resolve problem, then you can create temp WA in custom task

[uli]

thanks for your support. It was realla helpful. I'll just copy the fixed version of the generated file for now.

[turansky]

Do you check latest dukat version?

[turansky]

28 ?

[uli]

Yes I did. Still broken. So I added a note about noble to the ticket you mentioned above

[turansky]

@uli Whick kotlin version do you use?

[uli]

1.3.71 and 1.4-M1. Same result