altavir
10/08/2019, 2:26 PMRobert Jaros
10/08/2019, 3:31 PMaltavir
10/08/2019, 3:36 PMcore-js
added via gradle/yarn is not the same core-js
installed via npm. They have completely differen structure inside.altavir
10/08/2019, 3:37 PMaltavir
10/08/2019, 4:41 PMcore-js
even when I explicitely ask for newer version.snrostov
10/08/2019, 7:17 PMpackage.json
and yarn.lock
in build/js
?altavir
10/08/2019, 7:31 PMaltavir
10/09/2019, 6:04 AMaltavir
10/09/2019, 6:05 AM2.6.9
snrostov
10/09/2019, 6:56 AMdataforge-vis-dataforge-vis-common
, so it is visible only inside this module. Seems like it version should be used for kotlin-extensions
also, but kotlin-extension
is in top level, so for this module core-js is resolved to 2.6.9
.
It could be fixed by putting "core-js": "3.2.1"
in `kotlin-extension`'s package.json
or by using https://yarnpkg.com/lang/en/docs/selective-version-resolutions/ (you may put "resolutions": { "kotlin-extension/core-js":"3.2.1" }
) in root package.json
. Unfortunately it is not possible since both files will be overwriten in next build. I thinks we should fix kotlin-extension
publication. Will take a lookaltavir
10/09/2019, 6:59 AMcore-js
directly. It is used internally by kotlin-extension
. If it has wrong configuration, it should fail to build. By the way, the module itself should be supported better or even included in stdlib. I has a lot of useful things. It uses only one function from core-js. Maybe it is better to rewrite it in kotlin?snrostov
10/09/2019, 7:02 AMsince I do not useYou havedirectly.core-js
api(npm("core-js"))
in https://github.com/mipt-npm/dataforge-vis/blob/9f157a80b9352631e423507bf16d714618d2560d/dataforge-vis-common/build.gradle.kts#L23
If you remove this line, only one version will remain, but it comes from babel and karma, not kotlin-extension. So, yes, the root bug is that kotlin-extension is not published correctly.altavir
10/09/2019, 7:03 AM