In the case, if you would like to help to review d...
# javascript
b
In the case, if you would like to help to review declarations for Firebase welcome to the PR! https://github.com/Kotlin/js-externals/pull/22
👏 2
g
Very important thing for Firebase Functions is some helper method to register function as module. Because of this you cannot define FF just as public property https://youtrack.jetbrains.com/issue/KT-19016 Maybe make sense to add such helper function (actually, it’s just manual call of
module.exports = someFirebaseFunction
. Or js-externals must contain only external declarations and do not try to add helpers/wrappers/etc?
b
@gildor
js-externals must contain only external declarations and do not try to add helpers/wrappers/etc?
Would be nice to avoid adding non-external declarations to libraries in
js-externals
repo. But for some cases right now it’s impossible, e.g. for “plugins” that extends existing library by adding new members. In this case we have to use inline extension declarations. So this case is treated as exception. Maybe your example could be treated as exception too, at least until we provide a better solution. We’ll think about it.