Is this the correct way to turn an enum (in a util...

# android

[Florian]

Is this the correct way to turn an enum (in a utility class) to a localized readable string?

fun getHumanReadableName(context: Context) =
            context.getString(
                when (this) {
                    POMODORO -> R.string.pomodoro
                    SHORT_BREAK -> R.string.short_break
                    LONG_BREAK -> R.string.long_break
                }
            )

[Javier]

Screenshot_20210410-180812.jpg

[ephemient]

that's one way to do it. another:
enum class Time(@StringRes val key) {
POMODORO(R.string.pomodoro),

fun getHumanReadableName(context: Context) = context.getString(key)
}

[Florian]

@Javier that's actually pretty cool

[Florian]

@Javier Although then I can't pass the context

[Javier]

Abstract fun should allow pass the context I think

[ephemient]

which solution I'd choose depends on the situation. if it's always getString(constant), override fun in each enum is overkill IMO. but if there's more variation, then it may be appropriate

[Lefko]

Interesting article from Hannes Dorfman on the subject: https://hannesdorfmann.com/abstraction-text-resource/

[Javier]

it is not a good idea doing that

[Javier]

https://medium.com/androiddevelopers/locale-changes-and-the-androidviewmodel-antipattern-84eb677660d9

[Florian]

@Javier What are you referring to? I'm calling this method from the fragment so the locale should be updated properly

[Javier]

I was talking about the abstraction text resource post, there is no problem if you are using it on Fragments

[Florian]

ah, thank you