Hey all, wondering if someone (perhaps <@UJBPFB3SN...
# android
b
Hey all, wondering if someone (perhaps @Ian Lake?) could help me out here... I cloned the Github androidx repo, and setup my local dev environment according to the Contribution guide at https://github.com/androidx/androidx/blob/androidx-main/CONTRIBUTING.md. Everything seems great so far. I can open and build the
navigation
project ... But when I run tests according to the guide (I've made zero changes. Just cloned the repo, open the project build, run tests), they fail...
Copy code
cd navigation
# Run device side and host side tests
./gradlew test connectedCheck

.....

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':navigation:navigation-safe-args-gradle-plugin:test'.
> There were failing tests.
Am I doing something wrong?
i
Safe Args tests are a bit weird to run. Maybe @Jeremy Woods has an idea
b
Thanks @Ian Lake I think I have them working. I'm working to submit a PR to fix this issue on the bounty list. https://issuetracker.google.com/issues/135857840 Curious if you think the solution I posted there is good?
i
I think you could shorten it down the whole
parseValue
method with
type.enumConstants.firstOrNull
, but yes, that general approach seems reasonable to me
b
Cool. I'll post a PR and get some feedback there. Thanks!