Hi everyone a question, I don't think it is mentioned in the docs anywhere. When overriding ViewMode...

# android

[Anastasia Finogenova]

Hi everyone a question, I don't think it is mentioned in the docs anywhere. When overriding ViewModel's onCleared is calling super.onCleared() required and what are possible consequences of not calling it , does anyone know?

[Giorgos Neokleous]

Source Code seems like no consequences. Looks like a default implementation to prevent users from stubbing it out.

[zalewski.se]

So the easiest would be just to check the sources 🙂 There you can notice that onCleared() is empty inside and its being called at the end of clear() method. So it’s just a callback to clear your own subscriptions.

[Anastasia Finogenova]

@zalewski.se I did that , but then I checked other lifecycle super calls like onViewCreated etc and they are also all empty

[Anastasia Finogenova]

But as we know they are required and that mentioned In the docs so not sure what's up there

[Ian Lake]

Methods should be explicitly marked as @CallSuper if you need to call super

[Ian Lake]

super.onViewCreated() has never been a required call, hence why it doesn't have @CallSuper

[Anastasia Finogenova]

Ah ok I see it in onCreate for example

[Ian Lake]

If you find any exceptions to that, please file a bug

[Anastasia Finogenova]

Thanks!