Hi there, did anyone use this guy before? <https://github.com/android/architecture-components-sample...

# android

[Joao Birk]

Hi there, did anyone use this guy before? https://github.com/android/architecture-components-samples/blob/master/NavigationAdvancedSample/app/src/main/java/com/example/android/navigationadvancedsample/NavigationExtensions.kt

Im trying to use it with a custom toolbar per fragment, the back button is not showing up. Did anyone use this with custom toolbar in their fragments successfully?

[Matt Lien]

I did use a toolbar in the fragments, but to get the back button to show up I had to explicitly set the setDisplayHomeAsUpEnabled(true) for the fragments I wanted to provide that interaction.

(view.context as? AppCompatActivity)?.supportActionBar?.setDisplayHomeAsUpEnabled(true)

[Joao Birk]

yep, same here

[Joao Birk]

but for some reason, the back button shows, but when clicking on it nothing happens

[Matt Lien]

In the activity that is hosting the fragment, you would need to override the onSupportNavigateUp() method.

[Matt Lien]

If you are using a "tabbed" activity each with their own navigation graph (like in that example github project) it would look like this:

override fun onSupportNavigateUp(): Boolean {
    return currentNavController?.value?.navigateUp() ?: false
}

[Joao Birk]

yep, did that

[Matt Lien]

In your fragment with the toolbar, are you overriding "onOptionsItemSelected"?

[Joao Birk]

yep

[Joao Birk]

override fun onOptionsItemSelected(item: MenuItem): Boolean =
    when (item.itemId) {
        android.R.id.home -> {
            findNavController().popBackStack()
            true
        }
        else -> super.onOptionsItemSelected(item)
    }

[Matt Lien]

so you are handling the navigate up there. If that is the only thing you are looking for in that method, I would just comment it out.

[Joao Birk]

i removed, same thing, nothing happens.

[Joao Birk]

do u call this in your custom toolbar?

[Joao Birk]

val appBarConfiguration = AppBarConfiguration(setOf(R.id.home_tab))

[e-mail](findNavController(), appBarConfiguration)

[Matt Lien]

I have let the activity handle the navigation.
In the fragment, I just set the support action bar in the activity with the toolbar from the fragment.

//Setup the Toolbar
toolbar = view.findViewById(R.id.toolbar)
toolbar?.let {
    (activity as? AppCompatActivity)?.setSupportActionBar(toolbar)
}

[Joao Birk]

yep, weird

[Joao Birk]

if i add

toolbar.setupWithNavController(findNavController())

[Joao Birk]

in the fragment after the setSupportActionBar

[Joao Birk]

works fine

[Joao Birk]

now i have trouble to have the hamburger menu open the navdrawer

[Joao Birk]

and i did call

setupActionBarWithNavController(navController, binding.sidebarDrawerLayout)

[Matt Lien]

Im not sure I can help you much on that path, I haven't had much interaction with Drawer Layout recently.

[Joao Birk]

no worries, thank you so much for the help! i wasnt sure if setting the support action bar was the right approach...but its seems is the only one that works