Kotlin as a language is comfy though barring the Android bit

Question

Mikael Alfredsson · Answer

Moving to a thread since you have a big question I think you have over engineered the dialog popup but I don t know all requirements so im not sure

Mikael Alfredsson · Answer

you can inherit from DialogFragment and just open it as a normal fragment instead of dealing with window objects directly

Gavin Ray · Answer

I didn t engineer any of this at all which is part of the problem I have never even done Android development before This app was outsourced to foreign developers before I came on to the company =

Gavin Ray · Answer

Sorry for the long series of texts I should have definitely put it in a thread on the first comment my mistake

Mikael Alfredsson · Answer

so you basically just want to add a new button opening the same dialog as you can open from another page as well

Gavin Ray · Answer

Yeah if you see the image that pop up screen on the bottom of the two screens is currently triggered from the join button on the left screen I just need to trigger that from the new floating Join button on the right screen

Mikael Alfredsson · Answer

where does the `joinGameButton ` function live in which class

Gavin Ray · Answer

The function to trigger it is coded as a private method into `GameFragment` though I tried making it public doing `val gameFragment = GameFragment newInstance ` inside of `DetailFragment` and then `gameFragment joinGamePopup ` but it breaks because of `Dialog context ` inside of the `joinGamePopup ` method in `GameFragment`

Gavin Ray · Answer

gt where does the `joinGameButton ` function live in which class GameFragment

Mikael Alfredsson · Answer

does it use alot of other data from GameFragment or could you extract it to a new class

Mikael Alfredsson · Answer

context is easy to pass in as an argument to the new class but do you need anything else

Mikael Alfredsson · Answer

let me explain the problem a fragment doesn t actually have a context the context is the activity that the fragment is attached to so if you just create a new instance of a fragment and then try to get the context you will get `null`

Gavin Ray · Answer

So the arguments that it takes are an instance of `JoinGameModel` which has some information about the game the player is trying to join and `position` which after several hours I figured out is a magic variable that gets passed into fragments denoting their index I was able to recreate the `JoinGameModel` instance because it gets `gameData` from the parent fragment GameFragment and I tried hardcoding `0` `1` as the `position` to try to trigger it on the first or second fragment

Mikael Alfredsson · Answer

so if you can extract the function to its own class make sure that you pass JoinGameModel in as a parameter from either screen that opens this dialog and context as a second parameter this should work nicely

Gavin Ray · Answer

It looks like `Dialog context ` is where most of the stuff happens in that method This seems to create the pop up window and populate it with info So assuming I can have the right `context` value in there it should work right

Gavin Ray · Answer

Yeah but what is `context`

Gavin Ray · Answer

```class GamesFragment Fragment SwipeRefreshLayout OnRefreshListener var context MainActivity = null```

Gavin Ray · Answer

```private fun joinGamePopup gameJoin JoinGameModel position Int val dialog = Dialog context ```

Gavin Ray · Answer

```2020 03 11 13 22 50 418 26091 26091 com plei dev E AndroidRuntime FATAL EXCEPTION main Process com plei dev PID 26091 java lang NullPointerException Attempt to invoke virtual method android content res Resources$Theme android content Context getTheme on a null object reference at android app Dialog lt init gt Dialog java 175 at android app Dialog lt init gt Dialog java 149 at com plei screens games fragment GamesFragment joinGamePopup GamesFragment kt 246 at com plei screens games fragment DetailFragment$ initialize$1 onClick DetailFragment kt 92 ```

Mikael Alfredsson · Answer

context is and object in android that holds more or less all important stuff It tells you the current theme language resourcefile pointers screen measurements and what not Application Activity and Services has contexts with minor differences but fragments doesn t so they have to get teh context form the outside e g Activity

Mikael Alfredsson · Answer

```joinGamePopup context Context gameJoin JoinGameModel position Int ```

Gavin Ray · Answer

So I need to figure out how to get the context from the parent `GameFragment` into the `DetailFragment` function here to pass into context

Mikael Alfredsson · Answer

no you should not try to pass contexts between fragments yourself the OS will make sure you have a context in your fragment when its showing on the screen

Mikael Alfredsson · Answer

refactor the method to take context as a parameter and move it to a separate class so you don t have to instantiate GameFragment for this

Mikael Alfredsson · Answer

normally people use a DialogFragment instead which handles basically everything you have in line 2 to 18

Gavin Ray · Answer

Okay uhm I can add the `context` as an argument but moving it to a separate class may very well be out of the scope of my abilities with 48 hours of Android Kotlin experience

Mikael Alfredsson · Answer

learning by doing I think it will be fine

Mikael Alfredsson · Answer

just create a new kotlin class `GamePopup` or something

Mikael Alfredsson · Answer

move the popup function into that new class

Mikael Alfredsson · Answer

not trying to make something nice right now only getting it to work

Mikael Alfredsson · Answer

you could also just copy the function into your other fragment as well but that will be really ugly

Gavin Ray · Answer

Wait how is this even working if it says `context` is a type mismatch

Gavin Ray · Answer

gt but that will be really ugly This whole codebase is shudder

Mikael Alfredsson · Answer

it expects a non null variable and you are giving it a nullable variable

Gavin Ray · Answer

The dev used ID selectors to read values from text instead of data

Mikael Alfredsson · Answer

replace `context` with `requireContext` runtime you will get the same exception but the IDE might be happier

Mikael Alfredsson · Answer

or `context `

Gavin Ray · Answer

` ```var context MainActivity ```

Gavin Ray · Answer

Replace `MainActivity ` with `context `

Mikael Alfredsson · Answer

no but where you use it

Mikael Alfredsson · Answer

Activities are contexts so MainActivity can be casted to Context without any problem but you have MainActivity which can only be casted to Context notice the aka nullable sign

Gavin Ray · Answer

Ohhh

Gavin Ray · Answer

I didn t know Kotlin allowed types to be multiple things at once

Mikael Alfredsson · Answer

you have inheritance so you can always just extend a base object or and you can add interfaces to a class allowing the class to be typecasted to any ancestor or interface type

Gavin Ray · Answer

Okay so select the entire `joinGamePopup` and refactor it to a new class

Mikael Alfredsson · Answer

Lets see if that is possible depending on how many things it uses from the GameFragment but yes start with that

Gavin Ray · Answer

They really single purposed this

Mikael Alfredsson · Answer

no problem just continue slightly smiling face

Gavin Ray · Answer

Okay its extracted

Gavin Ray · Answer

```package com plei screens games fragment import androidx fragment app Fragment import com plei models JoinGameModel open class GamesFragment1 Fragment fun joinGamePopup gameJoin JoinGameModel position Int ```

Mikael Alfredsson · Answer

you should not have it in a fragment just a class called GamePopup

Mikael Alfredsson · Answer

```class GamePopup fun joinGamePopup gameJoin JoinGameModel position Int ```

Gavin Ray · Answer

Which of the refactor options is that

Gavin Ray · Answer

also where should I put the class file

Mikael Alfredsson · Answer

oh sorry with refactor i just ment the act of refactoring not any special IDE tricks

Gavin Ray · Answer

Ohh kk

Gavin Ray · Answer

So just create a file called `GamePopup kt` anywhere and paste that method in there

Gavin Ray · Answer

Put it in `screens games fragment`

Mikael Alfredsson · Answer

yep the placement of the file is less important

Gavin Ray · Answer

kk

Gavin Ray · Answer

Done ok hand

Mikael Alfredsson · Answer

in your GameFragment you can now create a ```val gamePopup = GamePopup ```

Mikael Alfredsson · Answer

somewhere in the beginning still not super solution but easiest to explain slightly smiling face

Gavin Ray · Answer

It s got a ton of un resolved references

Gavin Ray · Answer

Because it calls other methods and imports from the fragment

Mikael Alfredsson · Answer

GameFragment or GamePopup

Gavin Ray · Answer

GamePopup

Mikael Alfredsson · Answer

ok yea that is what i was afraid of Imports are easy the IDE will help you with that

Mikael Alfredsson · Answer

lets see which methods it complains about

Gavin Ray · Answer

```Unresolved reference paymentProcessPopup Unresolved reference Intent Unresolved reference startActivity Unresolved reference R Unresolved reference PaymentActivity Unresolved reference isPaymentAdded Unresolved reference joinGame Unresolved reference positiveButton Unresolved reference getButton Unresolved reference sharedPreference Unresolved reference AlertDialog Unresolved reference setBackgroundDrawable Unresolved reference Dialog Unresolved reference WindowManager```

Christophe Smet · Answer

Just pay a senior Android dev to look at it

Gavin Ray · Answer

< Christophe Smet> Lol no chance the business owners would pay money for that but I eventually got it after 14 hours thumbsup

Christophe Smet · Answer

haha too bad welcome to Kotlin and Android tho wink