https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
r

Remy Benza

02/13/2020, 7:21 AM
Why isn't there a coroutine Flow livedata builder which returns mutableLivedata?
This would be the 'old' patern:
class MyViewModel : ViewModel() {

private val _items = MutableLiveData<List<Item>>()

val items: LiveData<List<Item>>
        get() = _items

init {
        viewModelScope.launch {
            _items.value = fetchDataFromNetwork()
        }

}
With the new coroutines Flow livedata builder you can reduce this to:
val items: LiveData<List<Item>> = liveData {
     emit(fetchDataFromNetwork())
}
But what if I want to add logic inside my viewmodel that alters the value inside the 'items' value?
v

Vishal Choudhary

02/13/2020, 7:27 AM
I believe you need to use MediatorLiveData for that.
👍 1
r

Remy Benza

02/13/2020, 7:32 AM
Can you provide a code snippet that demonstrates this?
f

Faraz

02/13/2020, 8:19 AM
Just for Clarity: What is it you're trying to do? do you want to change the livedata value from viewmodel? If yes try changing the source of flow using
emitSource
this acts as a
MediatorLiveData.addSource
as Vishal said. Then something like this should work:
fun getItems(changeSource: () -> LiveData<List<Item>>) = 
	liveData { 
		
		emit(fetchDatafromNetwork())
		
		//change source
		emitSource(changeSource())
	}
But then this changing of source will be invoked from within livedata scope. So, if you want to change it from outside and want full control you can extend MediatorLiveData and run your coroutine scope inside it.
and the last sentence is the reason why you don't have builder which returns mutablelivedata, because you can always build one using
MediatorLiveData
which is also used in building the current flow livedata
r

Remy Benza

02/13/2020, 8:24 AM
Below my full code. I have logic for animations. I am fetching tags from a network API. I then alter the result inside the viewModel.
class OnboardingGetToKnowViewModel : ViewModel() {

    private val _onboardingTags = MutableLiveData<List<OnboardingTag>>()

    val onboardingTags: LiveData<List<OnboardingTag>>
        get() = _onboardingTags

    private var _selectedTags = MutableLiveData<List<OnboardingTag>>()

    val selectedTags: LiveData<List<OnboardingTag>>
        get() = _selectedTags

    fun addTag(tag: OnboardingTag) {
        val existingList = _selectedTags.value ?: emptyList()
        val newList = existingList + listOf(tag)
        _selectedTags.value = newList

        //for grid animation purpose change photo index so 1 becomes 3, 3 becomes 5 etc.
        val index = _onboardingTags.value!!.indexOf(tag)
        val list = _onboardingTags.value!!.toMutableList()
        for (i in index until _onboardingTags.value!!.size step 2) {
            val nextItem = list.getOrNull(i + 2)
            if (nextItem != null) {
                list[i] = nextItem
            } else {
                list.removeAt(i)
            }
        }
        _onboardingTags.value = list
    }

    fun removeTag(tag: OnboardingTag) {
        val existingList = _selectedTags.value ?: emptyList()
        val newList = existingList - listOf(tag)
        _selectedTags.value = newList
        //for grid animation purpose change photo index so it gets added at the top
        val oldPhotos = _onboardingTags.value!!
        val index = if (oldPhotos.size % 2 == 0) 2 else 3
        val list = oldPhotos.toMutableList()
        for (i in index until oldPhotos.size step 2) {
            list[i] = oldPhotos[i - 2]
        }
        if (oldPhotos.size > 1) {
            list.add(oldPhotos[oldPhotos.size - 2])
            list[index - 2] = tag
        } else {
            list.add(tag)
        }
        _onboardingTags.value = list
    }

    val lastItemTagged = Transformations.map(selectedTags) { list ->
        list.lastOrNull()
    }

    val secondLastItemTagged = Transformations.map(selectedTags) { list ->
        list.getOrNull(list.lastIndex - 1)
    }

    val extraItems = Transformations.map(selectedTags) { list ->
        list.size - 2
    }

    init {
        viewModelScope.launch {
            _onboardingTags.value = Services.followApi.fetchOnboardingTags()
        }
    }
}
z

Zach Klippenstein (he/him) [MOD]

02/13/2020, 3:36 PM
Seems like your code has a race - what if someone calls addTag before the service call returns, and then the call returns in middle of addTag executing, in between some of the accesses of _onboardingTags? Or if the call returns after addTag updates the value of _onboardingTags and overwrites it?
To your original question, that would mean the LiveData would have two+ sources of truth, which can make code tricky to reason about and result in races like this, for example.
1