Hey guys... Is it a bad practice to leave

logs

on the code (with the purpose of future debug)?

To quote Jake Wharton: “…every time you log in production, a puppy dies” It’s generally OK to leave logging statements in your code as long as they are effectively a no-op when run in production. Libraries like Jake’s Timber provide a wrapper around the standard

Log

class to allow that kind of flexibility. The normal Android Logger still writes logs in production, and so you should avoid calling it directly if you intend to leave them in your code

We use Timber.

logging is immensely helpful in troubleshooting. as far as where and when you log, there are lots of options

The situation that I told happened because in our team people tend to clean the logs before send to codereview

we tend to reject a PR if it doesn't have sufficient logging 🙂

Cool...

i would not recommend that myself, but to each their own

And then the devs think that after testing we should remove our logs

The main reason you’d want to turn off logging in production is so that potentially-sensitive information is never made visible to the end-user. Logcat is a global thing in Android with no protection around it, so other apps might be able to scrape API keys, PII, etc. from logs. I tend to check in lot of logging so that my QA team can identify problems and so I don’t have keep adding/removing them on my end while debugging. But logging is enabled in debug and QA builds only. Once a feature has been stable in production for a while, I tend to go back and remove its logs to keep everything clean

definitely keep PII out of logging

Yeah.. sure

Depending on nature of app you can also set logging levels and on/off via config flags remotely

ah! Good idea.

or with a user preference