Yes sorry that is correct it was a typo in the ex

Question

< nikolay> Yes sorry that is correct it was a typo in the example

nikolay · Answer

have you tried to debug where it gets stuck

ludwig · Answer

Yes it keeps thinking that it needs to parse toJson whenever it reaches the layer

ludwig · Answer

So it gets stuck in a recursion

nikolay · Answer

btw why here ` var type TypeEnum var layer Layer ` you have `var` maybe it should be `val`

ludwig · Answer

I ve tried that too it doesn t matter unfortunately

nikolay · Answer

have you tried without `toJson` as was suggested tbh not sure if it would work because I ve though that they are both mandatory

ludwig · Answer

it is mandatory so I can t try it

nikolay · Answer

maybe you could post JSON that you trying to parse

nikolay · Answer

I m really curious about issue because I m currently migrating to Moshi

ludwig · Answer

I can t post the exact one but it has the exact same structure as the example

nikolay · Answer

okey

ludwig · Answer

Other than this issue Moshi is great so don t be discouraged slightly smiling face

nikolay · Answer

Why have I asked about JSON because I have one idea Point is that I could not imagine what is coming in JSON under name `layer` Because from Response class I see that your JSON supposed to have 2 fields Something like ``` type X or Y layer not clear ``` My suggestion would be to have another class let s say `ResponseRaw` which would be exactly like your JSON and it should not include `Layer` in the structure Something like ``` type X or Y something variable1 1 variable2 2 data class ResponseRaw val type TypeEnum val something Something ``` And then your adapter would looks differently ``` class LayerAdapter FromJson fun fromJson response ResponseRaw Layer = when response type Y gt YLayer X gt XLayer ToJson fun toJson layer Layer ResponseRaw = when layer is YLayer gt ResponseRaw Y layer toSomething is XLayer gt ResponseRaw X layer toSomething ```

nikolay · Answer

I hope you get what I mean slightly smiling face

ludwig · Answer

Thank you very much for the effort and you re correct that works and that s an implementation that I can t use because we are using this format in almost every request and some of these layers have up to 30 different cases so it would be a huge mess when dealing with it hence why I want it to be explicit types that are being parsed directly slightly smiling face

nikolay · Answer

but I think Moshi simply could not parse your JSON to `Layer` because it doesn t know which one to pick

ludwig · Answer

But isn t that what I m trying to tell Moshi What to parse that is

nikolay · Answer

nope

nikolay · Answer

how should it distinguish which `Layer` to take

ludwig · Answer

What is the when layer is YLayer gt etc for then

nikolay · Answer

you should probably write more low level adapter that operates with strings ```class StageAdapter FromJson fun fromJson jsonReader JsonReader delegate JsonAdapter lt Stage gt Stage val value = jsonReader nextString return if value startsWith in progress Stage IN PROGRESS else delegate fromJsonValue value ```

nikolay · Answer

but you have `class Response var type TypeEnum var layer Layer `

nikolay · Answer

how would it parse Layer here

ludwig · Answer

Response = when layer is YLayer gt Response Y layer I m creating a new Response with the specified layer

ludwig · Answer

Response = when layer is YLayer gt Response Y YLayer

ludwig · Answer

Isnt that parsing the correct layer

nikolay · Answer

no it is already taking `Response` as param

nikolay · Answer

pass `jsonReader JsonReader delegate JsonAdapter lt Stage gt ` there

nikolay · Answer

or something

ludwig · Answer

I m talking about toJson btw

nikolay · Answer

nikolay · Answer

is it you slightly smiling face

ludwig · Answer

Nope just used the Layer as an example slightly smiling face

nikolay · Answer

```class LayerAdapter FromJson fun fromJson layerJson LayerJson Layer = when layerJson layerType LayerType SHAPE gt ShapeLayer layerJson layerType layerJson shape LayerType TEXT gt TextLayer layerJson layerType layerJson text LayerType IMAGE gt ImageLayer layerJson layerType layerJson image ToJson fun toJson layer Layer LayerJson = when layer is ShapeLayer gt LayerJson layer type shape = layer shape is TextLayer gt LayerJson layer type text = layer text is ImageLayer gt LayerJson layer type image = layer image else gt throw RuntimeException Not support data type ```

nikolay · Answer

that s more or less what I m trying to say

ludwig · Answer

Yes and I can t be using that because we are re using the Layer type everywhere which will then in some cases have 30 optional parameters as they have defined in that example

ludwig · Answer

I m trying to go one step further and not have that instead parse them out directly

nikolay · Answer

Let s say we have two JSONs ``` type X layer type LayerX prop 42 ``` and ``` type X layer type LayerY prop 100 ``` How Moshi could understand how to parse it to your `Response` class

ludwig · Answer

ToJson fun toJson layer Layer Response = when layer is YLayer gt Response Y LayerY prop = layer prop is XLayer gt Response X LayerX prop = layer prop Because the sealed class s has different fields on them

nikolay · Answer

man it takes as param `Layer`

nikolay · Answer

slightly smiling face

nikolay · Answer

but ``` layer type LayerY prop 100 ``` could not be parsed to `Layer`

nikolay · Answer

and I m talking about `fromJson`

ludwig · Answer

And I m talking about the toJson

ludwig · Answer

sealed class Layer class YLayer type String prop Int Layer And now it can be parsed

nikolay · Answer

no it can t I think

ludwig · Answer

The parsing works believe it or not because I get the object when I m doing it like this the only thing that isn t working as expected is when it s done it starts to nest the layer

nikolay · Answer

anyway I think either I don t understand the problem or I could not explain what I mean slightly smiling face

ludwig · Answer

The actual parsing from toJson and fromJson works when you run it once then I get the real objects depending on what type of Layer I send in or what Response is coming out It s when it s done parsing it starts to parse it again and again slightly smiling face

ludwig · Answer

Run it once using the debugger of course

nikolay · Answer

then I really don t get your issue sorry man

ludwig · Answer

Thanks for trying to help