Hey, just converted java class to kotlin and After...

# android

[alouanemed]

Hey, just converted java class to kotlin and After adding kapt to my gradle , the dagger component is not generated any more, anyone here can help?


apply plugin: 'kotlin-kapt'
...
implementation 'com.google.dagger:dagger:2.11'
kapt 'com.google.dagger:dagger-compiler:2.11'

[gildor]

Do you have any build errors?

[efemoney]

Have you tried to ./gradlew clean and/or rebuild project?

[denis.shakinov]

Did you add

kapt {
    generateStubs = true
}

to gradle file?

[alouanemed]

WelcomeContract.Presenter> cannot be provided without an @Provides- or @Produces-annotated method

[gildor]

You don’t need generateStubs = true

[alouanemed]

yeah, i don't have it .

[alouanemed]

@efemoney yeah done all that.

[alouanemed]

@Module class WelcomeModule {

@Provides fun providePresenterFactory(interactor: DragonInteractor): () -> WelcomePresenter {
return { WelcomePresenter(interactor) }
}
}

[efemoney]

Where is your @Provides method for WelcomeContract.Presenter ?

[gildor]

But this function returns lambda instead instance of class

[efemoney]

Exactly

[alouanemed]

aha?

[denis.shakinov]

@gildor from which version of kotlin plugin?

[alouanemed]

what's the correct syntax ?

[gildor]

@Provides fun providePresenterFactory(interactor: DragonInteractor): WelcomePresenter {
        return WelcomePresenter(interactor) 
}

[efemoney]

☝️

[alouanemed]

hah ! convert failed !

[gildor]

could you please show your original java code?

[efemoney]

Yeah you should probably report that on YT. If it was the converter that did that

[alouanemed]

YT ?

[gildor]

YouTrack

[efemoney]

YouTrack

[gildor]

Please show original code before you filled issue

[gildor]

@denis.shakinov Not sure, but it been there even before 1.1.
For now you should use only kapt3. kapt1 has a lot of problems and known bugs and not supported anymore. You need only kotlin-kapt plugin

[lovis]

exactly what Andrey says. kapt3 only and therefore no generateStubs

[alouanemed]

The lambda is already there 😕

[gildor]

I see, you original code returns PresenterFactory, that, as I suppose is SAM interface.

[gildor]

It’s not a fail of conversion, but yeah, this conversion doesn’t work properly with Dagger

[gildor]

@Provides fun providePresenterFactory(interactor: DragonInteractor): PresenterFactory<WelcomeContract.Presenter> {
        return PresenterFactory { WelcomePresenter(interactor) }
    }
}

[gildor]

@alouanemed Try this

[denis.shakinov]

@gildor so using kotlin plugin 1.1.4 and having kotlin-kapt in my gradle file means that I’m already using kapt3 and i can delete generateStubs everywhere?

[gildor]

@denis.shakinov yes

[denis.shakinov]

thank you

[alouanemed]

it says PresenterFactory ;Interface doesn't have constructor

[gildor]

@alouanemed PresenterFactory is Kotlin or Jva interface?

[alouanemed]

kotlin

[alouanemed]

interface PresenterFactory<T : BasePresenter<*>> {
fun create(): T
}

[gildor]

Oh, in this case you cannot use SAM conversion

[alouanemed]

why is that?

[gildor]

@alouanemed then you need to implement this interface:

@Provides
fun providePresenterFactory(interactor: DragonInteractor): PresenterFactory<WelcomeContract.Presenter> {
    return object : PresenterFactory<WelcomeContract.Presenter> {
        override fun provide(): WelcomeContract.Presenter {
            return WelcomePresenter(interactor)
        }
    }
}

[gildor]

@alouanemed see https://youtrack.jetbrains.com/issue/KT-7770

[alouanemed]

I see, what if I revoked back the Factory interface to java?

[alouanemed]

the old verison should work, right ?

[gildor]

@alouanemed Yeah this should work - https://kotlinlang.slack.com/archives/C0B8M7BUY/p1502793037000209?thread_ts=1502792341.000112&amp;cid=C0B8M7BUY

But I think there are 3 better options:
1) Implement interface as anonymous object, looks not so good, but works - https://kotlinlang.slack.com/archives/C0B8M7BUY/p1502793957000002?thread_ts=1502792341.000112&amp;cid=C0B8M7BUY
2) Write some simple wrapper for PresenterFactory to hold lambda
3) Use qulifier annotation on lamda, it will allow you to use lambda directly, but require refactor all client usages

[gildor]

for option 2:

class SimplePresenterFactory<T : BasePresenter<*>>(private val factory: () -> T) : PresenterFactory<T> {
    override fun create(): T {
        return factory()
    }
}

and then to use it:

@Provides
fun providePresenterFactory(interactor: DragonInteractor): PresenterFactory<WelcomeContract.Presenter> {
    return SimplePresenterFactory { WelcomePresenter(interactor) }
}

[alouanemed]

Thank you for the detailed answer. I opt ed for the first one (converting Factory to java)
that one is fixed, but am getting this bunch of errors in all my sub components :

Component.java5 error: incompatible types: NonExistentClass cannot be converted to Annotation
e:

e: @error.NonExistentClass()
e: ^

[alouanemed]

@ActivityScope @Subcomponent(modules = arrayOf(WelcomeModule::class)) interface WelcomeComponent {

[gildor]

Try to clean your project and build again

[gildor]

If you still has this problem after clean it means that you have some other problem and should check gradle build logs, reason is definitely there