``` fun searchParent(id: String): Module? { mod...

# android

[scruffyfox]

fun searchParent(id: String): Module?
	{
		modules.forEach { module ->
			val ret = searchParent(module, id)

			if (ret != null)
			{
				return@searchParent ret
			}
		}

		return null
	}

[kingsley]

return@searchParent does a local return (within the lambda) rather than a function return. You need to return ret instead

[scruffyfox]

i had that originally which was the problem

[kingsley]

Oh. Looking at your code. return@searchParent isn’t even valid code

[scruffyfox]

lol it compiles 😛

[kingsley]

What problem did you have with simple return xyz

[scruffyfox]

it continues the loop after i've returned

[scruffyfox]

i have a recursive datastructure and this basically loops through each one until it finds the matching ID then returns the parent object

[scruffyfox]

the recursive method:

[scruffyfox]

fun searchParent(root: Module, id: String): Module?
	{
		root.steps?.forEach { step ->
			val ret = searchParent(step, id)

			if (ret == null)
			{
				if (step.id == id)
				{
					return root
				}
			}
		}

		return null
	}

[minus]

return@searchParent should be correct (non-local return), but just use a for loop, it's shorter too

[scruffyfox]

yeah i think that'll probably be the best, just trying to use lambdas as much as possible to get used to them

[scruffyfox]

ok I fixed it! after writing it in plain java then refactoring it to kotlin worked cheers 👍