no, i updated with the full code: <https://gist.github.com/funrep/1ab655a69058f993d2237f8dfe64bf61>

# android

[funrep]

no, i updated with the full code: https://gist.github.com/funrep/1ab655a69058f993d2237f8dfe64bf61

[menegatti]

funrep: just starting a thread

[menegatti]

do you mind if I give some feedback?

[funrep]

sure!

[menegatti]

1st of all

[menegatti]

onCreateView()

[menegatti]

the onCreateView there doesn't have a ?

[menegatti]

which is exactly what's causing your issue it seems

[funrep]

you mean the return type of it or the call to super.onCreateView?

[menegatti]

the call

[menegatti]

on line 48

[menegatti]

oh no... that's not right

[funrep]

oh yeah, I forgot to annotate that bundle!

[menegatti]

cool

[menegatti]

try that

[funrep]

Didn’t even realize it said onCreate*View*, thanks a lot it works now!

[menegatti]

if it works then I can give some tips

[menegatti]

cool

[menegatti]

so, just some ideas

[menegatti]

2nd, why not initialize deliveries with an empty list from the start so you don't need to declare nullable?

[menegatti]

3rd, you can reduce line 36 to super.onCreate(savedInstanceState ?: Bundle())

[menegatti]

if the first parameter is null, the elvis operator ?: defaults to the second, does that make sense?

[funrep]

ah, great!

[menegatti]

and 4th, I recommend that you read about lateinit, but you can use in your listView, then you don't need to set it as nullable

[menegatti]

but overall, pretty good 😄

[funrep]

awesome feedback, thanks a lot!