https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
c

Colton Idle

04/11/2022, 10:51 PM
If I have
val data =
    hashMapOf(
            "firstName" to firstName,
            "lastName" to lastName)
but I wanted to not add firstName or lastName to the hashmap if they are null. What would be the best way to do that?
e

ephemient

04/11/2022, 10:58 PM
must it be a HashMap or are other maps allowed?
j

Joffrey

04/11/2022, 10:58 PM
Do you really need an explicit
java.util.HashMap
as output? In general it's more common to stick with
mapOf
or
mutableMapOf
. When building a read-only map, you can use
buildMap
with conditions inside:
val map = buildMap {
    firstName?.let { put("firstName", it) }
    lastName?.let { put("lastName", it) }
}
If what you need is a mutable map, you can also add stuff conditionally with `apply`:
val map = mutableMapOf<String, String>().apply {
    firstName?.let { put("firstName", it) }
    lastName?.let { put("lastName", it) }
}
c

Colton Idle

04/11/2022, 11:00 PM
I'm following firebases docs which have a hashMapOf, but I suppose I can try other maps? Shouldn't be an issue.
e

ephemient

04/11/2022, 11:01 PM
also options,
buildMap {
    firstName?.let { put("firstName", it) }
    lastName?.let { put("lastName", it) }
}

@Suppress("UNCHECKED_CAST")
fun <K, V> Map<K, V?>.filterNotNullValues(): Map<K, V> = filterValues { it != null } as Map<K, V>

mapOf("firstName" to firstName, "lastName" to lastName).filterNotNullValues()
https://firebase.google.com/docs/reference/android/com/google/firebase/functions/HttpsCallableReference#call(java.lang.Object)
The data passed into the trigger can be any of the following types:
• Any primitive type, including null, int, long, float, and boolean.
String
List<?>
, where the contained objects are also one of these types.
Map<String, ?>>
, where the values are also one of these types.
JSONArray
JSONObject
NULL
you do not need a HashMap, that Kotlin example was simply translated from Java
c

Colton Idle

04/11/2022, 11:03 PM
Thanks. I like the conciseness of just having the ext func. But TIL about buildMap!
r

Ruckus

04/11/2022, 11:04 PM
You can always make a helper function:
fun <K: Any, V: Any> nonNullHashMapOf(
    vararg entries: Pair<K?, V?>
): HashMap<K, V> {
    val map = HashMap<K, V>()
    for ((key, value) in entries) {
        map[key ?: continue] = value ?: continue
    }
    return map
}
And use it
val data = nonNullHashMapOf(
    "firstName" to firstName,
    "lastName" to lastName,
)
e

ephemient

04/11/2022, 11:05 PM
I would name it as
mapOfNotNull
just to match
listOfNotNull
better, but yeah that can also be done
c

Colton Idle

04/11/2022, 11:05 PM
Oooh boy! So many options!
e
r

Ruckus

04/11/2022, 11:06 PM
@ephemient That's probably a good idea. I'm not great at naming (like most programmers...)
e

ephemient

04/11/2022, 11:06 PM
I'm not great either, I'm just copying stdlib here :)
😁 1
c

Colton Idle

04/11/2022, 11:09 PM
If I use
fun <K: Any, V: Any> nonNullHashMapOf(vararg entries: Pair<K?, V?>) {
    val map = HashMap<K, V>()
    for ((key, value) in entries) {
        map[key ?: continue] = value ?: continue
    }
}
should I try to use a Regular map internally, or is HashMap alright?
r

Ruckus

04/11/2022, 11:10 PM
Use a hash map if you need a hash map for some reason, otherwise just use
mutableMapOf<K, V>()
e

ephemient

04/11/2022, 11:10 PM
if your function is named
hashMapOf
it should probably return a
HashMap
to reduce confusion 😛
r

Ruckus

04/11/2022, 11:11 PM
(By the way, I update my comment to include the return value, which I forgot the first time.)
e

ephemient

04/11/2022, 11:11 PM
in practice
MutableMap
is backed by a
LinkedHashMap
, so it is a
HashMap
in a sense
(but that's not a public API contract so don't rely on it)
2
c

Colton Idle

04/11/2022, 11:13 PM
Okay, so I'm using @Ruckus method you outlined, but @ephemient naming (stdlib naming). Anything else I should do to improve? (the only reason I asked about converting this to a regular Map instead of HashMap was because that was in the opening comment.
fun <K: Any, V: Any> mapOfNotNull(
    vararg entries: Pair<K?, V?>
): HashMap<K, V> {
    val map = HashMap<K, V>()
    for ((key, value) in entries) {
        map[key ?: continue] = value ?: continue
    }
    return map
}
r

Ruckus

04/11/2022, 11:13 PM
If you don't need a hash map:
fun <K: Any, V: Any> mapOfNotNull(
    vararg entries: Pair<K?, V?>
): Map<K, V> = buildMap {
    for ((key, value) in entries) {
        this[key ?: continue] = value ?: continue
    }
}
c

Colton Idle

04/11/2022, 11:15 PM
@ephemient I'll file a bug fore firebase docs to just be mapOf instead of hashMapOf
r

Ruckus

04/11/2022, 11:17 PM
With the new definitely non null types, this could also be
fun <K, V> mapOfNotNull(
    vararg entries: Pair<K, V>
): Map<K & Any, V & Any> = buildMap {
    for ((key, value) in entries) {
        this[key ?: continue] = value ?: continue
    }
}
Though I don't know if that's any better... https://blog.jetbrains.com/kotlin/2022/04/kotlin-1-6-20-released/#definitely-non-nullable-types
c

Colton Idle

04/11/2022, 11:19 PM
TIL "Definitely non-nullable types"
I'm going to go with this for now. Learned a ton in the past 15 minutes. Filed a bug. Thanks everyone for teaching!
👍 1
l

Landry Norris

04/12/2022, 9:39 PM
Just in case it’s helpful, GitLive has a library that lets you read and write kotlinx.serialization objects to/from firebase instead of using the HashMap based API. https://firebaseopensource.com/projects/gitliveapp/firebase-kotlin-sdk/
👍 1