hi is there better kotlin idiom for this one ? ```...

# getting-started

[althaf]

hi is there better kotlin idiom for this one ?

if (currencyInfo == null) {
    val assetData =
        JsonParser.getJsonDataFromAsset(context, "country_currency.json").orEmpty()
    currencyInfo = Gson().fromJson(assetData, CurrencyInfoResponse::class.java)
}

[gildor]

for what specifically?

[gildor]

assignment if variable is null?

[gildor]

currencyInfo = if (currencyInfo == null) {
…
} else {
currencyInfo
}

[jbnizet]

currencyInfo = currencyInfo ?: run {
    val assetData =
        JsonParser.getJsonDataFromAsset(context, "country_currency.json").orEmpty()
    Gson().fromJson(assetData, CurrencyInfoResponse::class.java)
}

[gildor]

In our code base we do not use run for this, imo if/else is more readable and explicit

[Joffrey]

IMO it's better to extract that code to a function, and use Elvis.
But using the variable itself in the RHS is a smell IMO, I'd rather initialize it with the correct value and make it val (using Elvis, if, or when expression), or use a different name for the assigned variable

[Vlad Krava]

it looks more like Java style to me.

Agree with @Joffrey, Elvis operator will fit here much better:

currencyInfo = currencyInfo ?: getCurrencyInfoFromJson(context, "currency_info.json")

or so