hi is there better kotlin idiom for this one ```if currencyI kotlinlang #getting-started

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

a

althaf

01/21/2022, 6:38 AM

hi is there better kotlin idiom for this one ?

if (currencyInfo == null) {
    val assetData =
        JsonParser.getJsonDataFromAsset(context, "country_currency.json").orEmpty()
    currencyInfo = Gson().fromJson(assetData, CurrencyInfoResponse::class.java)
}

g

gildor

01/21/2022, 7:12 AM

for what specifically?

assignment if variable is null?

currencyInfo = if (currencyInfo == null) { … } else { currencyInfo }

j

jbnizet

01/21/2022, 7:20 AM

currencyInfo = currencyInfo ?: run {
    val assetData =
        JsonParser.getJsonDataFromAsset(context, "country_currency.json").orEmpty()
    Gson().fromJson(assetData, CurrencyInfoResponse::class.java)
}

➕ 1

✅ 1

g

gildor

01/21/2022, 7:28 AM

In our code base we do not use run for this, imo if/else is more readable and explicit

j

Joffrey

01/21/2022, 8:25 AM

IMO it's better to extract that code to a function, and use Elvis. But using the variable itself in the RHS is a smell IMO, I'd rather initialize it with the correct value and make it val (using Elvis, if, or when expression), or use a different name for the assigned variable

✅ 1

☝️ 4

v

Vlad Krava

01/21/2022, 1:10 PM

it looks more like Java style to me. Agree with @Joffrey, Elvis operator will fit here much better:

currencyInfo = currencyInfo ?: getCurrencyInfoFromJson(context, "currency_info.json")

or so

✅ 1

#getting-started Join Slack