I have programmed a mini-class for practicing Kotlin. I'm getting really confused with how I could p...

# getting-started

[Carrascado]

I have programmed a mini-class for practicing Kotlin. I'm getting really confused with how I could properly initialize these class properties without repeating the operations. I'm trying that whenever you initialize the Time class with more than 59 minutes, or more than 59 seconds, it automatically gets adjusted

[Dominaezzz]

That's a weird ctor IMO. I think you should just assert that the params are within range, instead of handling the overflow.

[Dominaezzz]

Then maybe have a Time.fromMinutes(...) .

[Dominaezzz]

You can reference the properties in init using the this qualifier.

[Carrascado]

Honestly it's just for the sake of practice, although I see it very convenient that some kind of "Value Object" like this could handle the overflow by itself

[Carrascado]

Thank you for the suggestion, I don't know If it's more readable than before 😂

[Carrascado]

But it's true that it feels more natural to me this way

[Carrascado]

I guess the intrinsic complexity of handling that overflow can't be lower than that

[Carrascado]

In case that I just asserted the values are within the desired range, would you use some built-in exception in Kotlin? Or would you create one? @Dominaezzz

[Dominaezzz]

Actually, I think you're missing an edge case

[Dominaezzz]

val totalMinutes = minutes + (second - this.seconds) / 60 right?

[Dominaezzz]

Use a bult in exception I think. There should be one.

[Carrascado]

Umm according to the tests the implementation of the pic is correct 🤔

[Carrascado]

They are all green

[Dominaezzz]

Ohhh I see.

[Dominaezzz]

Yh weird ctor.

[Carrascado]

In case you needed that kind of overflow handling what would you do instead of making the constructor handle it?

[Dominaezzz]

Time.fromHours(...) + Time.fromMinutes(...) ......

[Carrascado]

Are those static methods? Sorry, I don't understand very well what do you mean

[Dominaezzz]

They should exists in the companion object of the Time class

[Dominaezzz]

Have methods to convert single units to a time object. Then a plus operator to handle overflows and such.

[Carrascado]

Thank you! More people think the same, that constructor is a bit ugly

[Matteo Mirk]

If you don’t want to repeat the calculations as you originally asked, just create private methods and use them in the constructor