```private fun getActiveFilters categoryId Int String val ac kotlinlang #getting-started

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

o

oday

04/01/2020, 1:59 PM

private fun getActiveFilters(categoryId: Int): String? {
        val activeFilters =  mutableFilterItems.value?.mapNotNull {
            it.takeIf { filterItem ->
                filterItem.categoryId == categoryId && filterItem.toggled
            }
        }?.joinToString { it.itemValue.capitalize() }
        
        return activeFilters
    }

s

spand

04/01/2020, 2:02 PM

return activeFilters?.takeIf { it.isNotEmpty() }

?

o

oday

04/01/2020, 2:09 PM

yea true, was looking for something like ternary or some kung fu stuff

s

StavFX

04/06/2020, 9:20 PM

Most glaring thing I see is the use of

mapNotNull + takeIf

could be replaced with a simple

filter

So combined with Johannes/Hakob’s suggestion

private fun getActiveFilters(categoryId: Int): String? {
   return mutableFilterItems.value
      ?.filter { it.categoryId == categoryId && it.toggled }
      ?.takeIf { it.isNotEmpty() }
      ?.joinToString { it.itemValue.capitalize() }
}

But I would definitely reconsider the use of nulls here, maybe return an empty String like @llsouder suggested

2 Views

#getting-started Join Slack