Is there a better way to write this ```val launchUri = try i kotlinlang #getting-started

val launchUri = try {
                if( isAvailable() ) {
                    Uri.parse( "..." )
                } else {
                    Uri.parse("..." )
                }
            } catch ( e : android.content.ActivityNotFoundException ) {
                if( isAvailable() ) {
                    Uri.parse( "..." )
                } else {
                    Uri.parse("..." )
                }
            }

tipsy

10/04/2018, 7:20 PM

pull out the uri to parse as a variable

Vladyslav Sitalo

10/04/2018, 7:20 PM

"..."

different in each case? also what is throwing the exception?

tipsy

10/04/2018, 7:21 PM

val uri = if(available) ... else ...
Uri.parse(uri)

Sam

10/04/2018, 7:21 PM

@Vladyslav Sitalo Yes, "..." is different

Nevermind, the exception was from a left over

This is the refactored code. Logic is to find an activity that can handle the URL if not launch a browser. This works fine except too many blocks without ?: operator

try {
                
                val launchUri = if( isAvailable() ) {
                    Uri.parse( "..." ) 
                } else {
                    Uri.parse("..." )
                }

                startActivity( Intent( Intent.ACTION_VIEW, launchUri ) )

            } catch ( e : android.content.ActivityNotFoundException ) {
                
                val launchUri = if( isAvailable() ) {
                    Uri.parse( "..." )
                } else {
                    Uri.parse("..." )
                }

                startActivity( Intent( Intent.ACTION_VIEW, launchUri ) )
            }

Ernest Zamelczyk

10/05/2018, 8:34 AM

Maybe try it like this?

val launchUri = if(isAvailable())
    Uri.parse("...")
else
    Uri.parse("...")
val intent = Intent(Intent.ACTION_VIEW, launchUri)

if(intent.resolveActivity(getPackageManager()) != null) {
    startActivity(intent)
else {
    //resolve new url and start activity
}

I don’t know exactly what is your logic because you don’t tell us if there’s 4 different uris or 2 or 3

ianbrandt

10/05/2018, 2:31 PM

@Sam, This and the prior are good posts for #codereview if you haven’t already seen that channel. 😊

Sam

10/05/2018, 2:33 PM

Sure, good to know

👍 1

2 Views

#getting-started Join Slack