Hello. I'm in doubt about on bevahior from all met...

# server

[Eduardo Pinto]

Hello. I'm in doubt about on bevahior from all method on Collections:

/**
 * Returns `true` if all elements match the given [predicate].
 * 
 * @sample samples.collections.Collections.Aggregates.all
 */
public inline fun <T> Iterable<T>.all(predicate: (T) -> Boolean): Boolean {
    if (this is Collection && isEmpty()) return true
    for (element in this) if (!predicate(element)) return false
    return true
}

Does this condition: if (this is Collection && isEmpty()) return true makes sense? Should return true for applying a predicate to an empty collection?
Example:

val s = emptyList<String>()
if (s.all { it.isNotEmpty() }) {
    // should  the code  enter here?
}

[gildor]

yes, it makes sense. all always return true for empty collection

[Eduardo Pinto]

👍

[Eduardo Pinto]

Yeah, I miss the basics here.
All languages have the same behavior for this function.

[Marko Mitic]

all === noneDont

[Shawn]

If you’re curious about how this works out from the set theory point of view: https://en.wikipedia.org/wiki/Vacuous_truth

[Stephan Schroeder]

the first line seems like overhead to me. is it even faster in the case it's defined for? Is an if with two conditions really faster than iterating an empty iterator??

[Eduardo Pinto]

Really nice @Shawn!

[Eduardo Pinto]

If here is Stackoverflow I will give a +1 🙂