Hi guys, I don’t know what I doing wrong but my ne...

# rx

[fstn]

Hi guys, I don’t know what I doing wrong but my next is never call inside the subscribe

rx.Observable.merge(
        events.map{
               eventbus.rxSend(....).toObservalbe()
       }
}.subscribe(next,error)

[edwardwongtl]

flatMap instead of map

[fstn]

thanks 😉 why should I user flatMap for that?

[fstn]

and I remove the merge?

[fstn]

I can’t use flatMap because eventbus.rxSend(....).toObservalbe() is not a Iterable

[fstn]

Maybe that :

Observable.from(validEvents).flatMap { notifyNextNode(node, it, messageBody, send) }

[edwardwongtl]

Why a merge in the first place?

[fstn]

I have a list of observable, I need to return only one

[fstn]

to subscribe it in another place

[edwardwongtl]

I think there is a extension in RxKotlin that help convert List<Observable> into Observable

[fstn]

thanks

[edwardwongtl]

Not sure though

[fstn]

I’ll look

[fstn]

😉

[fstn]

Does it seem good to you?

validEvents.toObservable().flatMap { notifyNextNode(node, it, messageBody, send) }

[edwardwongtl]

events.merge().subscribe { notifyNextNode(...) }

[edwardwongtl]

Make use of Kotlin's extension function to make you code more readable and meaningful

[fstn]

👍 thanks

[fstn]

ok it returns now a list of subscription

[edwardwongtl]

How come a list of subs instead of a single sub?

[fstn]

ok, it was my fault, I have now a Subscription. What are the best practices, do a subscribe inside each function and return subscription or return observable from all function? And do subscibe only on the call chain on the top?

[fstn]

ok now thanks @edwardwongtl

[edwardwongtl]

I would return a Observable instead of Subscription, unless you need to execute it now.

[fstn]

yes I read a book about rxjava, it’s more clear now.
I should have started with that