Channels
#spring
Title
b
bjonnh
04/26/2019, 6:17 PMI have issues in :scripts when importing something from the namespace present in :services
If I remove the springboot dependencies it find it perfectly
Except that adding the dependencyManagement part doesn't seem to solve anything. Also intelliJ finds the import properly, it is really gradle that complains
ok moving the models to a library that is not in a spring boot application solve the issue
if anybody as an explanation of why, I would be happy to know
s
snowe
04/26/2019, 7:08 PMSince you are using spring boot 2, I would instead recommend using gradle's
platformyou didn't commit your gradle directory, so i'm not sure what gradle version you are using.
you can use it in gradle 4.6, but you need a special setting.
b
bjonnh
04/26/2019, 7:33 PMI'm using 5.2.1
s
snowe
04/26/2019, 7:33 PMthen I would suggest using
implementation(platform(..))b
bjonnh
04/26/2019, 7:36 PMok that seem to work
s
snowe
04/26/2019, 7:36 PM👍🏽
b
bjonnh
04/26/2019, 7:36 PMwell it was working before too
but at least it didn't seem to break anything 😛
s
snowe
04/26/2019, 7:37 PMyes, well they work the same way. but now you don't need that
dependencyManagement😉
b
bjonnh
04/26/2019, 7:37 PMoh neat
hmm if I remove it it fails to find the packages
should I put something special in the library?
s
snowe
04/26/2019, 7:40 PMwhat's the error?
b
bjonnh
04/26/2019, 7:40 PMunable to resolve <name of the spring package>
that's in :scripts that is importing models from :api-library
s
snowe
04/26/2019, 7:41 PMdoes it include the version? can you provide the project? or build.gradle.kts.
b
bjonnh
04/26/2019, 7:42 PMimage.png
oh wait
let me update the repo
s
snowe
04/26/2019, 7:43 PMyeah ha.
I was wondering 😂
b
bjonnh
04/26/2019, 7:43 PMok
now that's the repo I used and made that error
(you will realize that I have no idea what I'm doing…)
s
snowe
04/26/2019, 7:44 PMyou are still applying the plugin https://github.com/bjonnh/gradle-kotlin-spring-debug/blob/master/api-library/build.gradle.kts#L3
b
bjonnh
04/26/2019, 7:45 PMoh
s
snowe
04/26/2019, 7:45 PMyou don't need to use
applypluginsb
bjonnh
04/26/2019, 7:45 PM\o/
beautiful
s
snowe
04/26/2019, 7:45 PMyou don't need this if you are using the
platformb
bjonnh
04/26/2019, 7:45 PMI like that… the less lines I have in those files the better I feel
s
snowe
04/26/2019, 7:46 PMI don't see where you are using
platformb
bjonnh
04/26/2019, 7:46 PMin scripts
s
snowe
04/26/2019, 7:47 PMsorry, it seems you misunderstood.
b
bjonnh
04/26/2019, 7:47 PMlikely
s
snowe
04/26/2019, 7:47 PMplatformdependencyManagementb
bjonnh
04/26/2019, 7:47 PMnope
so I should remove that dependencyManagement also from api-library?
s
snowe
04/26/2019, 7:48 PMBOM stands for Bill Of Materials. It is essentially a parent pom that declares what versions of libraries should be used. Are you familiar with maven?
b
bjonnh
04/26/2019, 7:48 PMa tiny bit
enough to break things
should I remove that dependency management completely
s
snowe
04/26/2019, 7:49 PMhaha. ok, so if you have a parent pom, you can declare a bunch of dependencies in a
<dependencyManagement>I will send a pr.
give me a sec.
b
bjonnh
04/26/2019, 7:50 PMyes that's exactly what I'm trying to do
so I don't have to give the spring versions in each submodule
s
snowe
04/26/2019, 7:50 PMwhat version of gradle are you using?
oh sorry 5.2.1
b
bjonnh
04/26/2019, 7:52 PMnow that I removed the dependencymanagement everywhere, no submodule finds the versions for spring modules
at least they all agree on that
s
snowe
04/26/2019, 7:52 PMyep, give me just a minute.
b
bjonnh
04/26/2019, 7:53 PMsure
s
snowe
04/26/2019, 8:07 PMhmm. this is kinda a mess 😅
it's taking much longer than normal for me to fix it.
b
bjonnh
04/26/2019, 8:09 PMyes that's the feeling I have everytime I touch gradle. And looking at other people repositories, they all have completely different ways of handling things
so it is hard to find a reference implementation for anything
s
snowe
04/26/2019, 8:17 PMdo you want me to make the pr the way I would do it?
or follow your style and try and fix it your way?
b
bjonnh
04/26/2019, 8:17 PMabsolutely
I have no style
you can burn anything you want
s
snowe
04/26/2019, 8:17 PM😂
b
bjonnh
04/26/2019, 8:17 PMI'm really lego-ing things until they work
s
snowe
04/26/2019, 8:26 PMso, if you look at the root build.gradle.kts file you'll now see the BOM implementation in the
allprojectsthis applies the BOM to all projects, allowing the versions to resolve.
I completely removed the spring dependency management plugin.
b
bjonnh
04/26/2019, 8:32 PMThanks
never seen that nebula.kotlin
s
snowe
04/26/2019, 8:33 PMit just adds a BOM for kotlin essentially. makes it so you don't have to track versions through the rest of the project.
b
bjonnh
04/26/2019, 8:34 PMcool
ok I'm done integrating the changes in my real app
lets see if it blows up 😄
s
snowe
04/26/2019, 8:36 PM😂
b
bjonnh
04/26/2019, 8:43 PMhey
it also removed all the duplicate tasks I had in gradle
🎆 Thanks @snowe
s
snowe
04/26/2019, 8:52 PMawesome! you're welcome! some of those things just come with time. I've only been using gradle for a few months, but it's been getting much easier.
b
bjonnh
04/26/2019, 8:53 PMyep I'm learning a lot of stuff at the same time, and programming is not my main job so…
s
snowe
04/26/2019, 8:53 PMoh!
wow. well good job then! haha
that's the kind of stuff I do with kotlin ^
s
snowe
04/26/2019, 8:55 PMoh nice!
5 Views