Simon Schubert

    Simon Schubert

    3 years ago
    I have released a kotlin multiplatform project. it's a (nextcloud) rss news reader and I would appreciate feedback 🙂 https://github.com/SimonSchubert/NewsOut
    Nikky

    Nikky

    3 years ago
    your code quality badge links to a different project
    b

    bdawg.io

    3 years ago
    It's one of his project though. You've never pushed something that you've copy and pasted?
    Nikky

    Nikky

    3 years ago
    i did
    Simon Schubert

    Simon Schubert

    3 years ago
    Fixed it, thanks
    Lou Morda

    Lou Morda

    3 years ago
    This is really cool! My first question was what did he use for the web client, Ktor! Nice. For the Actual.kt files, is it safe to use GlobalScope? I'm wondering if there would be a better scope to use, or if you had to use this one.
    Simon Schubert

    Simon Schubert

    3 years ago
    You are absolutely right. Global scope shouldn't be the best to use. I will try to refactor it in the next release. Any hints or a push on GitHub are very welcomed.
    Dico

    Dico

    3 years ago
    I noticed you're not using coroutines in shared/Api.kt
    Instead using callbacks
    Simon Schubert

    Simon Schubert

    3 years ago
    I will refactor the coroutine part