https://kotlinlang.org logo
#feed
Title
s

Simon Schubert

03/28/2019, 11:21 AM
I have released a kotlin multiplatform project. it's a (nextcloud) rss news reader and I would appreciate feedback 🙂 https://github.com/SimonSchubert/NewsOut
🎉 6
👏 12
n

Nikky

03/28/2019, 3:49 PM
your code quality badge links to a different project
b

bdawg.io

03/28/2019, 4:11 PM
It's one of his project though. You've never pushed something that you've copy and pasted?
n

Nikky

03/28/2019, 5:13 PM
i did
s

Simon Schubert

03/29/2019, 12:39 AM
Fixed it, thanks
👍 1
l

Lou Morda

04/04/2019, 11:39 PM
This is really cool! My first question was what did he use for the web client, Ktor! Nice. For the Actual.kt files, is it safe to use GlobalScope? I'm wondering if there would be a better scope to use, or if you had to use this one.
s

Simon Schubert

04/07/2019, 8:34 PM
You are absolutely right. Global scope shouldn't be the best to use. I will try to refactor it in the next release. Any hints or a push on GitHub are very welcomed.
👍 1
d

Dico

06/18/2019, 5:28 PM
I noticed you're not using coroutines in shared/Api.kt
Instead using callbacks
s

Simon Schubert

06/19/2019, 4:39 AM
I will refactor the coroutine part
5 Views