https://kotlinlang.org logo
Channels
Powered by
#feed
Title
# feed
d

digitalsanctum

12/14/2018, 11:31 PM
o

orangy

12/14/2018, 11:34 PM
omg, these builders… Of course, Java API and all, but…
@egorand seriously, why not an idiomatic DSL?
e

egorand

12/14/2018, 11:56 PM
We've had an ongoing discussion about this ever since the early days of KP, and came to the conclusion that builders are still the most flexible approach in our case
Java compat is rather a nice to have
o

orangy

12/14/2018, 11:59 PM
I would be very interested to read a blog post about making the decision here 😉
e

egorand

12/15/2018, 12:01 AM
Yeah, I can try to compile all the pro/cons into a blog post
Anyway, people are successfully building their own DSLs on top of KP, which I think is a win
o

orangy

12/15/2018, 12:04 AM
Agree, I think a DSL can be easily generated with some reflection and KotlinPoet 🙂 But a standard one maintained with the lib to avoid desyncs would still be nice.
Hm, I disagree with @jw here: https://github.com/square/kotlinpoet/issues/435#issuecomment-410533943 DSLs are as composable as builders, you just pass a builder as a reciever instead of a parameter. Same extract function facilities, same reusability. May be I’m missing something important 🤷‍♂️ There is also several mentions of “builders API is more flexible”, but without any real cases when something is doable with builders and not doable (or has other cons) with DSL.
e

egorand

12/15/2018, 12:39 AM
Classic DSLs pretty much confine you to the property definitions, so if 
FunSpec
has a 
kdoc: CodeBuilder
property, you can either set it, or modify it if it's mutable, but you can't expose APIs such as 
addKdoc(format: String, vararg args: Any?)
Well, you might invent your own syntax to achieve this of course
j

jdemeulenaere

12/15/2018, 2:34 PM
Nice! Now if we could have a Gradle plugin that (when compiling Kotlin files) takes as input the ASTs of the elements annotated by some annotations and allows to generate new FileSpecs, it would be awesome 🙂
e

egorand

12/15/2018, 2:55 PM
That's pretty much what SQLDelight does, only that it compiles SQL into Kotlin
j

jmfayard

12/15/2018, 11:43 PM
I wrote a Gradle plugin with Kotlinpoet. It is good! Builders are not really a problem once you are into it. Some simple things should be easier IMHO like a TypeSpec with properties defined in the constructor
o

orangy

12/16/2018, 10:42 AM
@egorand I didn’t understand this:
Classic DSLs pretty much confine you to the property definitions
you can have a 
kdoc { … }
or whatever signature you want in the DSL. Basically it can look something like this:
Copy code
type {
    primaryConstructor { 
           kdoc("Creates an instance")
    }
    property<String>("foo", "initExpression()") 
}
13 Views
Powered by