hey all, I'm hoping someone can help me with somet...

# kodein

[james]

hey all, I'm hoping someone can help me with something here

is there a way to access the binding tag from within the provider block? eg.:

bind<Retrofit.Builder>(tag = AuthType.OAUTH) with provider {
        Retrofit.Builder()
            .client(instance<OkHttpClient>(tag = /* How do I access the tag used above on provider line? */))
            .addConverterFactory(JsonConverterFactory())
    }

the use case here is that for some cases, the provider block might be many lines, and I don't want to have to repeat the code for each new AuthType , so I was wondering can I just pass that through, rather than repeat the code each time.

is something like this possible?

[romainbsl]

Hi, indeed this is possible. nevertheless. tag wont help you in this case.

[romainbsl]

If you need to pass arguments at retrieval, you should use factory binding, this is like provider, but with parameter.

[romainbsl]

giving you something like that

bind<Retrofit.Builder>(tag = AuthType.OAUTH) with factory { param ->
        Retrofit.Builder()
            .client(instance<OkHttpClient>(tag = param))
            .addConverterFactory(JsonConverterFactory())
    }

[romainbsl]

you can find documentation here https://kodein.org/Kodein-DI/index.html?latest/core#_factory_binding

[romainbsl]

and if you need to retrieve the same object regarding to the parameter, you should use multiton that could alos be called are singleton factory

[james]

thanks so much for the response, Romain

[james]

I can't seem to get it quite working, Kodein doesn't seem to recognise the factories when I attempt to use them

[james]

org.kodein.di.Kodein$NotFoundException: No binding found for bind<Retrofit.Builder>(tag = "OAUTH") with ? { ? }
Available bindings for this type:
        module com.myframework.NetworkModule {
            bind<Retrofit.Builder>(tag = "OAUTH") with factory { AuthType -> Retrofit.Builder }
            bind<Retrofit.Builder>(tag = "EMAIL") with factory { AuthType -> Retrofit.Builder }
        }

[james]

it even lists the available bindings, and the one it says it can't find is actually identical to one in the list

[romainbsl]

Can you share your bindings declaration and your factory call ?

[james]

sure

[james]

this works:

bind<Retrofit.Builder>(tag = AuthType.OAUTH) with provider {
        getRetrofitBuilder(okHttpClient = instance<OkHttpClient>(tag = AuthType.OAUTH))
    }

[james]

but this does not:

bind<Retrofit.Builder>(tag = AuthType.OAUTH) with factory { authType ->
        getRetrofitBuilder(okHttpClient = instance<OkHttpClient>(authType))
    }

[james]

the second one compiles, but throws the aforementioned binding error at run-time

[romainbsl]

how do you retrieve your bindings? this is certainly where the error occurs

[james]

oh, right, my apologies

[james]

it's retrieved by another module, like this:

bind<ApiService>() with provider {
    instance<Retrofit.Builder>(tag = AuthType.OAUTH)
        .baseUrl(AuthModule.BaseUrl)
        .build()
        .create(ApiService::class.java)
}

[romainbsl]

ok, I think this where the issue is, a factory is a function that needs an input parameter, in your case authType, the tag parameter of the instance() isn't a factory parameter, but a way to manage different instances of the same type. In your case I'm not sure that you need to tag your bindings.

[romainbsl]

Plus you should have named the type of your factory param. In your factory you also are doing something like instance<OkHttpClient>(authType)), this means that you also have another factory for the type OkHttpClient ?

[romainbsl]

Is what I would have done (not tested)

[romainbsl]

OkHttpClient factory

bind<OkHttpClient>() with factory { authType: AuthType ->
    OkHttpClient>(authType)
}

Retrofit.Builder factory

bind<Retrofit.Builder>() with factory { authType: AuthType ->
    getRetrofitBuilder(okHttpClient = instance<OkHttpClient>(arg = authType))
}

ApiService provider

bind<ApiService>() with provider {
    instance<Retrofit.Builder>(arg = AuthType.OAUTH)
        .baseUrl(AuthModule.BaseUrl)
        .build()
        .create(ApiService::class.java)
}

[romainbsl]

let me know if this help