https://kotlinlang.org logo
#kontributors
Title
# kontributors
j

Junjie Wu

12/20/2021, 2:45 AM
Hi team, if I want to take one issue (KT-xxxx) to kontribute. Should I get assigned first or just go ahead and raise a pull request then find someone to review it?
d

dmitriy.novozhilov

12/20/2021, 7:32 AM
Hi. AFAIR external users can not change
Assignee
field, so you can just comment in issue that you will work on it and then just mention issue number in your PR
j

Junjie Wu

12/20/2021, 7:33 AM
🙏
d

dmitriy.novozhilov

12/20/2021, 7:35 AM
BTW which issue you want to fix?
j

Junjie Wu

12/20/2021, 9:35 AM
@dmitriy.novozhilov I’m trying to fix this one: https://youtrack.jetbrains.com/issue/KT-50372
do you have any concerns?
d

dmitriy.novozhilov

12/20/2021, 9:36 AM
I don't cc @ilya.gorbunov
j

Junjie Wu

12/20/2021, 6:18 PM
Hi @dmitriy.novozhilov @ilya.gorbunov, I’ve put up a PR for the KT-50372, could you please help review it? PR link: https://github.com/JetBrains/kotlin/pull/4686
i

ilya.gorbunov

12/21/2021, 7:52 AM
Hi, thanks for the PR. I can a look at it, but please note that since we have not yet made a decision to include this function in the standard library, do not expect it to be merged soon.
👌 1
j

Junjie Wu

12/21/2021, 8:37 AM
Thanks @ilya.gorbunov for the review, just wonder in Kotlin how do we make decision on whether or not to add stdlib functions like this one? Will there be any public discussions we can be involved?
i

ilya.gorbunov

12/21/2021, 8:38 AM
You can greatly influence the positive decision by providing compelling use cases in the corresponding YouTrack issue.
j

Junjie Wu

12/21/2021, 8:39 AM
makes sense 👍
Hi, just want to follow up the issue, I’ve added some context that might be helpful on the decision making, could you please take a look?
7 Views