What's an appropriate time to wait before nudging ...
# kontributorsa
adam-mcneilly
02/02/2018, 4:07 PMWhat's an appropriate time to wait before nudging a PR? I submit one to the website two weeks ago, but it hasn't been acknowledged. I thought it might be at least be assigned to someone (even if accepting/denying it came later), but that hasn't happened yet.
adam-mcneilly
02/02/2018, 4:09 PMAnd if two weeks is enough time, then nudge https://github.com/JetBrains/kotlin-web-site/pull/995
l
ltongues
02/02/2018, 4:12 PMI can’t speak for Jetbrains here, but I think that for a simple PR such as this 2-3 days is reasonable
👍 1
ltongues
02/02/2018, 4:12 PM@h0tk3y Could you please take a look?
a
adam-mcneilly
02/02/2018, 4:13 PMI had similar thoughts, but I understand they're busy so I don't want to nudge if it's not urgent haha.
h
h0tk3y
02/02/2018, 4:18 PMThanks for the PR, I'll take a look at it shortly. Sorry for taking so long, I've been on a vacation for the last two weeks. 🙂
👍 1
a
adam-mcneilly
02/02/2018, 4:18 PMRelated, there was another thread a few days ago about how the website doesn't appear to have been updated in a while.
Someone found a May 2017 commit that still doesn't appear.
adam-mcneilly
02/02/2018, 4:18 PMOh, no worries! Thank you for taking a look. Hope you had a good vacation. 🙂
h
h0tk3y
02/02/2018, 4:19 PM@adam-mcneilly Yup, we resolved that. The grammar reference was not re-generated automatically.
a
adam-mcneilly
02/02/2018, 4:21 PMAh okay. I said on the same thread that some of my code samples that were merged a while ago still don't appear either. For exampe: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.properties/-delegates/vetoable.html
I believe the samples should have been updated when version 1.2.20 was released?
h
h0tk3y
02/02/2018, 4:24 PMSorry, we haven't updated the stdlib docs yet since the 1.2.20 release. We are aware of that and will do it soon.
👍 1
a
adam-mcneilly
02/02/2018, 4:24 PMNot a problem! As long as you're aware, I did my part. 🙂
2 Views