https://kotlinlang.org logo
#exposed
Title
# exposed
p

Philip Walford

06/09/2020, 7:28 AM
Hey, I’ve raised a pull request to improve (in my opinion) the implementation of
replace
for h2sql. It passes the standard build, but I’m not really sure where to proceed from here. The Contribution guide says to
Submit Pull Request on review.
but I’m not sure what that actually means. What are the next steps after creating a PR?
t

tapac

06/09/2020, 2:39 PM
I'll take a look into it when have a free time. Btw, thank you for your PR.
p

Philip Walford

06/10/2020, 12:11 AM
Thanks Andrey 🙂. I’ve got another one for implement
batchReplace()
once that one’s in.
batchReplace()
is actually what I’m after, but the current h2sql replace implementation doesn’t support batch operations…
👍 1
20 Views