@tapac I was thinking about adding some missing Javadoc and also fixing the code formating which in some places is crazy.
And I wanted to know if I should make one big PR for the documentation and one for the formating, multiple PR in each case.
Also about formating, I think there should be some guidelines about what code style contributors should follow and maybe committing files in folders
.idea/codeStyles/
and
.idea/inspectionProfiles/
👍 2
t
tapac
01/14/2020, 11:09 PM
Hi, @SackCastellon.
Let's start with default kotlin code-style and then fix it.
I don't really want to put .idea/* files into the project as they could hardly depend on a idea/kotlin-plugin versions. I guess that it's better to give a try to something like
detekt/ktlint + .editorconfig.
About PRs, I would prefer several medium sized PRs or it could take too much time to review and sccept them. You could mix formatting and documentation in a single PR.
Thank you for spending time to help Exposed become better!
