Channels
#exposed
Title
# exposed
o
oshai
02/26/2018, 12:35 PM@tapac - after upgrading to 0.10.1 the following do not compile:
transaction(statement)t
tapac
02/26/2018, 12:37 PMtransaction(statement = statement)transaction(null, statement)o
oshai
02/26/2018, 12:37 PMyes the first works
the question is isn't it better to add another method instead of breaking the cmpatibility?
to make it more clear, I think it is better to add another method in this case (easier to use)
should I add a PR?
t
tapac
02/26/2018, 12:59 PMNot sure that this requires another method. I guess that it's a rare case when you don't use lambda, but provide statement as parameter.
Adding new function will require to annotate it with @JavaName, because it will clash with existing one with optional parameter.
I think, that before 1.0 (which I hope will be reached someday) it's ok to change API a bit.
o
oshai
02/26/2018, 1:04 PMI agree it is ok to change the api
what I suggest for convinience is to have two method: one with one parameter which is the transaction and one is 2 parameters. this way they will not clash, the method with one parameter will just called the second one with null