Crossposting as probably tied to Kotlin 1.4 : I'm ...

# eap

[Tolriq]

Crossposting as probably tied to Kotlin 1.4 :
I'm getting a very weird issue and wonder if someone have already seen that, before trying to find a small repro. On some suspending functions an Android

TextView.getText().toString() == ""

works but

TextView.text.toString() == ""

(As suggested by IDE and previously worked) triggers java.lang.ClassCastException: android.text.SpannableStringBuilder cannot be cast to java.lang.String. It's like in the second case the .toString() call is converted to a cast and not the proper toString()

[louiscad]

Hello, please consider using formatting like that for readability 🙂

[louiscad]

Or like that for multiline.

[Tolriq]

Yep forget sorry. Anyway it's definitively a Kotlin compiler issue 😞 Adding just a simple run {} wrapping the call fixes the issue 😞

[gildor]

it indeed looks like a compiler issue with suspend functions

[louiscad]

Does it reproduce with IR enabled?

[gildor]

want ask the same, I have a similar issue with IR and Result

[Tolriq]

Same with both -Xnew-inference and without

[gildor]

no, it’s not about type inference

[louiscad]

new-inference is abbreviated "NI", but that's not full IR

[gildor]

https://kotlinlang.org/docs/reference/whatsnew14.html#new-jvm-ir-backend

[Tolriq]

will test just after testing with apilevel 1.3, full build is slowwwwwww on this large project 😞

[louiscad]

I wonder if it'll be quicker with IR 🤔

[Tolriq]

I doubt I think it's slow because of Windows and too many files badly handled by system 😞

[Tolriq]

Well e: java.lang.IllegalStateException: Backend Internal error: Exception during IR lowering

[louiscad]

Worth reporting on kotl.in/issue, preferrably with a reproducing snippet or project so they fix it before it's the default or only option.

[louiscad]

I mean, both issues are worth reporting.

[Tolriq]

the second one will be impossible to repro it's a private very large project and the failure occurs on a very large file that is long waiting a refactor 😛

[Tolriq]

For the first one I still need to figure out proper repro 😞

[gildor]

same issue, reported IR crash recently, but I have no idea how to reproduce it, my issue was clossed with “Cannot reproduce” 🙄

[Tolriq]

Yep kotlin support is far from optimal 😞 Got some major build speed issues with incremental and they just vanished from the issue 🙂

[louiscad]

I guess they hope to see it again with clue to reproduce it 🤷‍♂️

[louiscad]

Or hope other changes will end up fixing it. After all, they are still working on it and they "only" need to get it stable in 2021 for Jetpack Compose 1.0

[Tolriq]

Do any one of you know a black magic thing to find all TextView.text called from suspend functions ? 🙂

[gildor]

I really don’t think that it’s the case, I think it’s some more tricky case

[louiscad]

@Tolriq Possibly structural search and replace that is not fully baked and available as a separate plugin. https://youtrack.jetbrains.com/issue/KT-10176#focus=Comments-27-4256401.0-0

[gildor]

I wouldn’t update if there is such bug there

[Tolriq]

Unfortunately this was only spotted after going to public beta 😉 Reverting will be a lot of work 😞

[gildor]

I think it worth to revert

[gildor]

fortunately we catch a few similar crashes in tests and postoponed update

[gildor]

or maybe check 1.4.10 or 1.4.20 (master) to see was it fixed or not

[gildor]

because I wouldn’t be comfortable to have possibility to get ClassCastException on runtime if someone accidentally changed getText() to text

[louiscad]

There's dev versions published with a special repo, more convenient than compiling all Kotlin yourself I'd assume

[gildor]

yeah, I mean try to use versions from dev repo

[Tolriq]

Trying to build a repro first then I'll see what I do 😞 thanks for support 🙂

[Tolriq]

Well completely unable to reproduce 😞

[nitrog42]

I think 1.4.20 contains many fixes about thoses issues unfortunatelly it will only be released in a few months

[nitrog42]

I have many issues with the Result class so I’m staying on Kotlin 1.3.72 for now