i.e. both dependant on internet as part of the test.. good? bad?

# test

[ursus]

i.e. both dependant on internet as part of the test.. good? bad?

[tenprint]

🤔 to me it's not the same

having tests against a real REST api, there are numerous reasons things can fail that are not related to your code, like you mentioned internet, server goes down, the API changes, etc

Firebase Test Lab will run your instrumented tests on emulators or real devices, but it's still running your test code. These could be espresso tests, activity/fragment scenarios, etc. So it's still your environment to control. However, yes it's possible that there's service interruption (it did happen to me before)

[ursus]

isnt the same for test lab? its comunicating from client to server via some api, it can be dont, new version etc

[ursus]

but we just wave hand since its considered stable

[tenprint]

yeah true
honestly I have written tests against a remote REST API 🙂

[tenprint]

maybe when ppl say you shouldn't do that, it is in cases where you do not control the remote REST service

with firebase test lab you have control over the environment (i think? it's been 6-7 months since i used it, starting to forget 😞 )

[ursus]

Well, tests are fine, but should they fail a merge? Probably not

[tenprint]

I believe in our set up, they did not block merging