<@U0F3291QE> what other things need to be complete...

# tornadofx

[Bogdan]

@edvin what other things need to be completed in jdk 10 branch ?

[abhinay]

The most important part is testing it against applications for potential bugs

[Carlton Whitehead]

Is there anywhere particular that feedback should be consolidated? Are there specific applications still having issues?

[abhinay]

That's what we want to know 😁

[altavir]

You won't get actual feedback untill it is released to a major repository. So I suggest to publish it as soon as possible. If anyone have problems, they can always roll back to previous version.

[Bogdan]

+

[altavir]

You can even mark versions like -dev or -rc or -eap, but still it should be a repository, not the build-it-yourself.

[abhinay]

It has always been inside the snapshot repository: https://oss.sonatype.org/content/repositories/snapshots/no/tornado/tornadofx/2.0.0-SNAPSHOT/

[abhinay]

Snapshots are releases for both master and jdk10 branch.

[altavir]

Snapshot is very hard to test and suggest changes to.

[abhinay]

How is it hard to test? You just need to add a repository to your build file and then add the dependency. If anything in the application breaks, you report it back to Github issues.

[altavir]

I mean that it could randomly change every day. If we are moving project or library to new API, then we are doing it once and then starting to fix bugs both in project and in tornado. Working with snapshot usually means maintaining both old and new version of project since it could produce random irreproducable degradations and failures. We are using strict versioning even in inside projects because it is hard to understand which bug version of origin and rollback to older version otherwise.

[altavir]

IMO, snapshots are OK only for closed project and only in early development stage. Something like 2.0-dev-22 works better.

[abhinay]

I am not asking you to use the snapshot version in production. Just replace tornado 1.x with 2.0.0-SNAPSHOT and check if the application works. That all I was asking 🙂

[altavir]

I can say now, that it probably won't work, since there are slight changes in API, but I will try.

[abhinay]

Exactly. When it doesn't work, we need to fix/document the things that's required to make it work 😇

[altavir]

I am not sure, that keeping the same API is the aim of migration. I am OK if some API is changed.

[abhinay]

You will have to change the JavaFX skin package imports. Rest everything should work as it is.

[abhinay]

If it doesn't we need to fix it or document the changes that is required to make it work.

[Bogdan]

@altavir The jdk10 branch API currently corresponds to the main branch. Not sure what was deployed, but manual assembly works. It remains to find bugs