i can't seem to get a DataGrid updated, when the m...

# tornadofx

[iari]

i can't seem to get a DataGrid updated, when the maxCellsInRowProperty changes.
it seems I should be able to call private fun updateItems() on DataGrid ...

[Bogdan]

do you pass observableList to DataGrid?

[Bogdan]

datagrid(observableList)

[iari]

yes sure.

[Bogdan]

show how you add new elements, without just an example it's hard to help

[iari]

datagrid<LabelContent> {
hgrow = Priority.ALWAYS
maxCellsInRowProperty.bind(data.columns)

data.columns.onChange {
DataGridSkin::class.java.getDeclaredMethod("updateItems").apply {
isAccessible = true
invoke([e-mail])
}
}

itemsProperty.bind(data.data)

cellFragment<LabelContentFragment>()
}

[iari]

this is the code I'm using right now.
It works when i use the hack via reflection.

[iari]

In the line

itemsProperty.bind(data.data)

I make sure, that the data for the grid is bound priopertly.
data.data is defined in an ItemViewModel:

class LabelsDocumentDataModel : ItemViewModel<LabelsDocumentData>() {
// ... other stuff
val data = bind(LabelsDocumentData::data)
}

[iari]

where in LabelsDocumentData data is defined as an observable list:
val data = observableListOf<LabelContent>()

[iari]

Let me know if I can somhow unwrap that better for you.

[Bogdan]

datagrid(data) - does not work ?

[Bogdan]

cellFragment<LabelContentFragment>() - you have your own fragment, you need to make sure that it can resize

[Bogdan]

updateItems- called when updating your list

[iari]

listview<T> can be called with a Property<ObservableList<T>>
internally Listview then does just the same as i do: it binds the property to its itemProperty.

datagrid can only be called with an ObservableList directly.

[iari]

I do not want my fragment to resize.

[Bogdan]

axCellsInRowProperty.bind(data.columns)

data.columns.onChange {
DataGridSkin::class.java.getDeclaredMethod("updateItems").apply {
isAccessible = true
invoke([e-mail])
}
} - meaning then in this code? it's a reflection

[iari]

yes, this is a reflection which is neededd, because i want to make the Datagrid update its layout

[iari]

I want the maxCellsInRowProperty of the datagrid to take effect. For that problem I don't think that it would matter whether i have a fragment or just a simple Label to display the content of the data list.

[iari]

so when i change maxCellsInRow from 2 to 3, it should display 3 columns instead of 2

[iari]

what does happen without my reflection hack is the following:

[iari]

1. maxCellsInRow is 2, i change it to 3

[iari]

then nothing happens, the datagrid still displays 2 columns

[iari]

then I change the content of the list (for example i add another item)

[iari]

after that the datagrid does relayout, and everything is fine, i hvae 3 columns now

[Bogdan]

this code also needs to be shown, which does not work

[iari]

well, probably i could make a minimal example ,...

[iari]

because there is too much real-world application BS going on in my code, that isn't helpful to understand the problem

[iari]

Omg ... this is horrible ... I cannot even add a simple observablelist to the datagrid ...

[iari]

Now I got it - look at this:

[iari]

class Test : View("Test") {
val myData = observableListOf<String>()
val maxCols = SimpleIntegerProperty(3)

override val root = vbox {
hbox {
button("add") {
action {
myData.add("str-${myData.size}")
}
}

spinner(1, 10, 3, 1, true, maxCols)
}

datagrid<String>(myData) {
maxCellsInRowProperty.bind(maxCols)
}
}
}

[iari]

this is the most simple view that shows the problem i have.

[Bogdan]

t starts to work after redrawing, how to send a signal I have not yet found

[Bogdan]

I recommend to write issue https://github.com/edvin/tornadofx

[Bogdan]

class Test2 : View("Test") {
    val myData = observableListOf<String>()
    val maxCols = intProperty(2)

    override val root = vbox {
        hbox {
            button("add") {
                action {
                    myData.add("str-${myData.size}")
                }
            }
            spinner(1, 10, 3, 1, true, maxCols)
        }
        datagrid<String>(myData) {
            maxCellsInRowProperty.bind(maxCols)

            maxCols.addListener { _, old, new ->
                val oldValue = old.toInt()
                val newValue = new.toInt()
                println("$height:$width")
                if (oldValue < newValue) {
                    minWidth = width + 100.0 // not work scroll
//                    currentStage?.let { it.width += 100.0 }
                } else if (oldValue > newValue) {
                    minWidth = width - 100.0 // not work scroll
//                    currentStage?.let { it.width -= 100.0 }
                }
            }
        }
    }
}

[Bogdan]

maxCellsInRowProperty - only sets the maximum possible amount, but does not determine the current, for this you need to change the size itself

[iari]

thanks, but what does that have to do with the problem? I do not want to change the width of the stage or window at all

[Bogdan]

This is the width of the datagrid. I conducted an experiment and found out that even if you increase maxCellsInRowProperty and expand the window, the elements cannot be selected. This behavior resembles FlowPane.

[Bogdan]

it’s nothing more than a workaround

[Bogdan]

I comment a little bit in the code above, now updated

[Bogdan]

minWidth = width +- widthItem +- spaceItems