<https://medium.com/@hinchman_amanda/tornadofx-mig...
# tornadofxa
amanda.hinchman-dominguez
05/27/2019, 4:29 AMa
abhinay
05/27/2019, 4:33 AMCan you transform openJFX -> OpenJFX ? 🙂
😆 1
a
amanda.hinchman-dominguez
05/27/2019, 4:34 AMTotally 😄
amanda.hinchman-dominguez
05/27/2019, 4:36 AMfixed!
a
abhinay
05/27/2019, 4:36 AMGluon did a very cool thing and offered to maintain openJFX. Go ahead and download thenecessary SHAplatform specific runtime for your system here.
💯 1
abhinay
05/27/2019, 4:36 AMThe link can be updated to: https://gluonhq.com/products/javafx/
a
amanda.hinchman-dominguez
05/27/2019, 4:37 AMI’ll add a thank you at the bottom for your proofreading as well!
a
abhinay
05/27/2019, 4:37 AMYou are missing a
l--module-path /Users/${wherever you unpacked the package}/javafx-sdk-11.0.2/lib --add-modules=javafx.controls,javafx.fxm
💯 1
a
amanda.hinchman-dominguez
05/27/2019, 4:38 AMAlso @carlw and @alex @elexx for their help w the beginning part
a
abhinay
05/27/2019, 4:39 AMCan we please change the placement of this image?
a
amanda.hinchman-dominguez
05/27/2019, 4:39 AMyep! What did you have in mind?
a
abhinay
05/27/2019, 4:40 AMJust place it in between paragraphs like other images, aligned to center.
a
amanda.hinchman-dominguez
05/27/2019, 4:40 AMAh - sure!
amanda.hinchman-dominguez
05/27/2019, 4:42 AMLet me know if you’d like me to link your names somewhere specific. For now, I have attached them to Twitter profiles (or Github if I know that)
a
abhinay
05/27/2019, 4:43 AMAnother small comment. The part "Migrating to OpenJFX" talks more about setting up OpenJDK.
abhinay
05/27/2019, 4:43 AMMost of them can move to the section: "Getting set up with OpenJDK 11"
a
amanda.hinchman-dominguez
05/27/2019, 4:48 AMOkay - how do the headers look now?
a
abhinay
05/27/2019, 4:51 AMLooks good 👍
i
ianbrandt
05/27/2019, 3:07 PMA couple potential typos stood out to me. You might consider changing “openJDK” to “OpenJDK”, and “jdk8” to “JDK 8”.
Thanks for putting this together! I’m looking forward to trying TornadoFX on JDK 11.
a
amanda.hinchman-dominguez
05/27/2019, 3:12 PMThanks! I'll get these things corrected. Hopefully the transition will be smoother for you than it was for some of us 😅
amanda.hinchman-dominguez
05/27/2019, 3:12 PMTo be honest I didn't know what the proper naming convention was haha
😊 1
4 Views