https://kotlinlang.org logo
Join Slack
Powered by
<@UH7J3DVPA> <@U78L28DMX> If you guys are migratin...
# tornadofx
a
@Stephane M @amanda.hinchman-dominguez If you guys are migrating to JFX 11 and you hit a roadblock, you can ping me. There might be a chance I left something undone on the 
jdk10
branch.
s
if the app launches with TornadoFX and JDK 11, I'm assuming everything is working correctly? 😛
a
Basically, yes. You just need to use the 
jdk10
branch on TornadoFX to build a jar and use it in your project.
s
I actually didn't even have to.... so will I get an error in the future?
It literally worked out of the box by just reference the maven dependency
a
which maven dependency are you referring to?
s
compile group: 'no.tornado', name: 'tornadofx', version: '1.7.18'
a
That doesn't look like a JDK 11 compliant release
s
yeah that's what I figured, but it's still "working"
is there any way for the tornado project to publish the JDK10-branch to maven somehow ? Would make usage and debugging a lot easier I guess
a
We can ask @edvin to release a snapshot version 🙂
e
@abhinay Absolutely, will fix
❤️ 3
I'm still not up to speed with the module system, that's why I'm procrastinating.. hehe.. Just tried to do a mvn deploy and get this:
[ERROR] Module java.base cannot be found in the module graph [ERROR] Module java.desktop cannot be found in the module graph [ERROR] Module java.xml cannot be found in the module graph [ERROR] Module java.prefs cannot be found in the module graph [ERROR] Module java.logging cannot be found in the module graph
Hang on, I'm stupid. I used J8 😁
s
FYI, here's a hack:
Copy code
repositories {
    maven { url "<https://jitpack.io>" }
}

dependencies {
    // hack thanks to jitpack
    compile 'com.github.edvin:tornadofx:jdk10-SNAPSHOT'
that works 🙂
e
"[WARNING] * Required filename-based automodules detected. Please don't publish this project to a public artifact repository! *"
Watch me, Maven.. 😎
😁 3
a
@edvin While you are on this, would you mind if I create a PR to release snashots from Travis?
e
@abhinay That would be very nice!
2.0.0-RC1 should be in Maven Central within the hour
a
Cool, thanks. I will create a PR once I have some free time.
e
Hmm.. it failed because javadoc was not created. I used to have a "Javadoc trap", maybe it's not in the jdk10 branch. Checking..
[ERROR] Failed to execute goal org.apache.maven.pluginsmaven javadoc plugin3.1.0:javadoc (default-cli) on project tornadofx: An error has occurred in Javadoc report generation: [ERROR] Exit code: 1 - error: module not found: tornadofx [ERROR] [ERROR] Command line was: "C:\Program Files\Java\jdk-11.0.1\bin\javadoc.exe" @options @packages @argfile [ERROR] [ERROR] Refer to the generated Javadoc files in 'C:\Users\edvin\Projects\tornadofx-j11\target\site\apidocs' dir.
@abhinay Looks like it isn't recognized as a module by javadoc. Do you have any idea how to fix this?
a
Javadoc is a mess. I will have a look into it. Can you release without the javadoc jar for now?
e
No, maven central states you need to have javadoc, it won't let me
a
ok. I will have a look at it when I have some free time.
e
Thanks!
The maven-javadoc-plugin was removed from pom in the jdk10 branch. Putting it back in and experimenting with it now
Huh. It seems the maven-javadoc-plugin ignores the excludePackageNames directive
Seems the issue is related to imports in module-info.java
Need to migrate to Dokka anyway. But this one is blocking us: https://github.com/Kotlin/dokka/issues/294
It might be possible to do the dokka step with jdk8
I built the javadoc file with jdk8, then signed it manually with gpg and I'll try to upload all the artifacts manually now so we can get an RC out there.
That failed as well.. grr..
s
Copy code
repositories {
    maven { url "<https://jitpack.io>" }
}

dependencies {
    // hack thanks to jitpack
    compile 'com.github.edvin:tornadofx:jdk10-SNAPSHOT'
}
If you can't somehow publish an RC right now, people can use the snippet above in their gradle to directly compile on the fly straight from your github as a dependency
a
I feel that hahaha I sympathize
I just got to Chicago Roboto but my goal is getting up to date with JDK 11 today!
a
@edvin This is sad. Issues like this will inherently block Kotlin projects to move to JDK 11.
a
honestly that's what has blocked me from moving any of my projects
e
@abhinay Yeah, it's really sad. Java 9 introduced changes the world just wasn't ready for, and with the level of dependencies on any given project (including dependency on the build tools), there are a lot of things that need to work right for us to be able to migrate. That a build tool isn't doing it's basic job after several years is kind of unforgivable though 🙂 Oracle hasn't made it easy either, but I guess in the long run this will be a good thing.
@amanda.hinchman-dominguez Is javadoc generation for J11 projects blocking you from moving any of your projects as well, or are you talking about TornadoFX perhaps? 🙂
a
Yeah, sure thing.
@edvin btw, I was hoping you could release a snapshot instead of RC. Generally snapshot repositories are much more flexible than release repositories.
e
Absolutely, will do it today!
Done 🙂
🎉 1
a
@edvin I just saw saw this. I'm talking about TornadoFX and projects that use it - I'm afraid I haven't even got there yet.
2 Views
Open in Slack
PreviousNext
Powered by