It looks like VirtualFlow is completely locked dow...
# tornadofxe
edvin
10/07/2017, 2:57 AMIt looks like VirtualFlow is completely locked down in Java 9. It's public and not final, but everything interesting is private. That sucks big time. I might need to implement a similar solution from scratch to get DataGrid up and running. Should also investigate how this is done in similar Java 9 compatible components, I suspect there are some in ControlsFX.
😱 3
n
nimakro
10/07/2017, 5:35 PMMhm that sounds not to good sorry that I can't help much right now, I need to get an tfx app ready for release on Monday so I will have to work all weekend 😉 But I hope at the end of next week I am back again.
e
edvin
10/07/2017, 5:37 PM@nimakro Don't worry, I will try to implement this in a naive way first, to get a POC up and running. I will ignore speed/optimizations just to see if I can get it to work. If that approach works for relatively large datasets, we can keep that approach until there is time to make a custom VirtualFlow we can use in other components.
a
abhinay
10/08/2017, 6:20 AM@edvin ControlsFX uses reflection to access most of the private fields/methods. You may want to look at GridViewSkin. It's a shame that they made
VirtualFlowVirtualContainerBaseabhinay
10/08/2017, 6:35 AMMoreover, I think that package-private VirtualFlow in VirtualContainerBase is a regression in 9. More information - https://bugs.openjdk.java.net/browse/JDK-8187379
e
edvin
10/08/2017, 11:27 AM@abhinay Thanks for the info. They effectively made sure that
VirtualFlowVirtualContainerBasecom.sunedvin
10/08/2017, 11:32 AMSeems like
cellsVirtualFlowedvin
10/08/2017, 11:34 AM@abhinay Doesn't this mean that even ControlsFX needs some command line parameter to be able to reflect on the JDK classes?
a
abhinay
10/08/2017, 1:20 PM@edvin Yes. You might be interested in this - https://bitbucket.org/controlsfx/controlsfx/src/c925e36f147f136f270ccde2a990fd13ab79ef8c/controlsfx-samples/build.gradle?at=9.0.0&fileviewer=file-view-default#build.gradle-41
abhinay
10/08/2017, 1:21 PMIn a normal Java application, you could have accessed the class without adding the jvm flag but since they have changed the package for this particular class, we need to explicitly open it up.
e
edvin
10/08/2017, 1:22 PM@abhinay Thank you for this. If at all possible I want TornadoFX to be usable without "dirty" settings like this, but we might need to opt for an intermediary step where we allow for such tricks 🙂
edvin
10/08/2017, 1:22 PMOnce the Jet Lag ™️ wears off I will try to create a simplified VirtualFlow inside GridPane to see if performance is acceptable. If not, I'll revert to hackery 🙂
a
abhinay
10/08/2017, 1:24 PMI was talking about the above issue with Jonathan and he said that it might not be fixed for 18.3. So, as of now ControlsFX is vulnerable and so is any other control using Virtual Flow. Rewriting them might be the best option as of now.
e
edvin
10/08/2017, 1:25 PM@abhinay That's really surprising to me. It looks like an oversight that could be fixed with very little work. I'm also surprised Jonathan didn't catch this before the release of Java 9. There is probably some things I don't know here, but it seems odd.
edvin
10/08/2017, 1:27 PMThe thing is, my current idea for a rewrite will not be performant for large datasets. I'm not sure what large means yet though. It could be several houndred thousand records or it could be 1k 😁
a
abhinay
10/08/2017, 1:27 PMI am on the same boat as you are. Moreover, OpenJDK doesn't make it easy to vote / comment on issues.
abhinay
10/08/2017, 1:28 PMIt would have been just easy for the OpenJFX team to fix these issues.
e
edvin
10/08/2017, 1:30 PMYes. Well, if my idea is viable we're safe for now. I think there is at least one other part of TornadoFX that uses internal classes through reflection, but that was already "tainted" in JavaFX 8, so a rewrite is long overdue anyways.
a
abhinay
10/08/2017, 1:32 PMI peaked into the code you pushed in the jdk9 branch. I would be really excited to see how you around the code which uses Toolkit 😄
e
edvin
10/08/2017, 1:34 PMI haven't committed my latest batch of trickery.. hehe.. What part which uses Toolkit would you be interested in?
e
edvin
10/08/2017, 1:36 PMHow to deal with
canStartNestedEventLoop()a
abhinay
10/08/2017, 1:36 PMYup
abhinay
10/08/2017, 1:36 PMNot sure if there is an alternative to them
e
edvin
10/08/2017, 1:37 PMI did find a "solution" to this, after beeing awake for 26 hours, on the way back. Let me check 🙂
edvin
10/08/2017, 1:38 PMThere are several ways to "trick" JavaFX into calling that method, actually.
edvin
10/08/2017, 1:40 PMYou could create a Dialog or Stage and call ShowAndWait, then kill it. That would throw
IllegalStateException!canStartNestedEventLoopa
abhinay
10/08/2017, 1:41 PM"dirty" hack 😞
e
edvin
10/08/2017, 1:42 PMYes. I wonder what the rationale is for removing these functions from the public API.
edvin
10/08/2017, 1:42 PMI really thought the migration to Java 9 would be about the module system. That was five minutes work 😞
a
abhinay
10/08/2017, 1:43 PMNeither do I...
abhinay
10/08/2017, 1:43 PMThey have introduced a lot of regression in JFX9 which makes life difficult for framework and custom control developers.
e
edvin
10/08/2017, 1:43 PMYes indeed. After getting TornadoFX up and running I'll make a list of senseless regression examples and submit issues.
👍 1
edvin
10/08/2017, 1:44 PMFor now I think using dirty hacks that only access public api's are our best shots, unless performance penalties kick in.
a
abhinay
10/08/2017, 1:45 PMIf you have access to the JBS, please vote on related issues as well 🙏
e
edvin
10/08/2017, 1:46 PMI will wait a little with passing judgement though. My head is still not on right after the flight back. I look at walls and they don't look straight anymore etc. Hehe.. Will pick this up again tomorrow, need to get my head on straight first.
edvin
10/08/2017, 1:46 PMI don't, but I'll for sure start lobbying once I get the big picture here.
a
abhinay
10/08/2017, 1:46 PMTake rest 🙂
abhinay
10/08/2017, 1:46 PMAnd stop replying to my messages 😛
e
edvin
10/08/2017, 1:46 PMProbably best. Thanks for your help so far 🙂 Talk to you later!
a
abhinay
10/08/2017, 1:46 PMLater!
e
edvin
10/08/2017, 2:27 PMFor
awaitUntiledvin
10/08/2017, 2:27 PMfun <T> ObservableValue<T>.awaitUntil(condition: (T) -> Boolean) {
val changeListener = object : ChangeListener<T> {
override fun changed(observable: ObservableValue<out T>?, oldValue: T, newValue: T) {
if (condition(value)) {
runLater {
Platform.exitNestedEventLoop(this@awaitUntil, null)
removeListener(this)
}
}
}
}
changeListener.changed(this, value, value)
addListener(changeListener)
Platform.enterNestedEventLoop(this)
}
edvin
10/08/2017, 2:28 PMThe reason is that
enterNestedEventLoopIllegalStateException("Cannot enter nested loop during animation or layout processing");a
abhinay
10/09/2017, 7:12 PMAhha nice!
4 Views