@tieskedh Not sure it adds much value to add generics to the App constructor as it would break backwards compatibility, and since you can't use generics with varargs, you'd have to resort to the old syntax for the stylesheets anyway.
t
tieskedh
09/03/2017, 7:36 AM
agree, I think you're right. created pulll requests. (many more are comming soon). I created a lot of rrefactorings, but never suggested them.
tieskedh
09/03/2017, 8:22 AM
ps. feel free to reject changes you don't like 😉
e
edvin
09/03/2017, 8:50 AM
Thank you! Will start going through them later today! If you have time, can you also update the CHANGELOG?
edvin
09/03/2017, 9:20 AM
No need for changelog entries for simple refactorings of course 🙂 Just actual changes in functionality.
edvin
09/03/2017, 9:23 AM
I added info about Launch<AppClass> to the CHANGELOG. We should update the guide as well 🙂
edvin
09/03/2017, 9:26 AM
I updated the guide 🙂
edvin
09/03/2017, 9:35 AM
@tieskedh Thanks for splitting these up into separate PR's - makes it much easier to review 🙂