How come all the for-alls in `io.kotlintest.data` ...
# kotlintest
j
How come all the for-alls in
io.kotlintest.data
are
forall
instead of
forAll
like the capitalization pattern applied in the rest of the library? It took 5 minutes for me to realize that the compiler was giving problems because I was using, and importing, the wrong for-all.
l
I belive it's probably due to how
ScalaTest
does it, and @sam had that design as inspiration
s
the
forAll
is from Scala yeah and the
forall
is from Kotlin. It's confusing - we need to change this.
j
@sam Is this something I could contribute? I've never worked on a unit test library before though. But this seems like a small enough change, maybe I won't be in over my head...
s
Absolutely
j
@sam Ok, cool. I'll get setup and reach out if I have questions. I suppose I should add an issue ticket first?
s
Yes. And I'd like to see the generation mode added to the new functions. And they could be inline too.
j
Np. Where can I find info about generation mode? I don't know what that is.
s
It's a new thing
Basically it determines how the values are generated
You could just add the enum with a single value for now
We also need to support passing in a seed