https://kotlinlang.org logo
Join Slack
Powered by
<@U12AGS8JG> would you be opposed to a PR for hopl...
# kotlintest
b
@sam would you be opposed to a PR for hoplite which allowed for comments in json? there's an option in jackson.
or maybe there's a better idiom to use?
s
absolutely that’s a good idea
no reason why it can’t be turned on
b
ok
trying to test and deploy to local but it wants 
signatory.keyId
, should that be needed just to publish to local maven? sorry, gradle noob.
s
do a pull and retry
b
hm, still the same
s
cat the gradle.proeprties file from the repo
b
i'm just trying to run 'publishToMavenLocal' from hoplite-json directly
s
run it from the top level task ?
b
same
Copy code
~/work/hoplite$ cat gradle.properties
#these should be overriden if you want to do release
signing.keyId=xx
signing.password=xx
signing.secretKeyRingFile=~/sksamuel.gpg

ossrhUsername=xx
ossrhPassword=xx

intellijPublishUsername=xx
intellijPublishPassword=xx

org.gradle.caching=true
sandbox = .
s
./cat gradle.properties
oh signatory
what’s that
are you using the gradlew ?
or your own older gradle ?
b
i was running from intellij
s
is that configured to use the gradle from the project (gradlew) or your own install of gradle
b
i just tried gradlew on the command line and get the same thing looks like:
Copy code
~/work/hoplite$ ./gradlew publishToMavenLocal

Welcome to Gradle 5.2.1!

Here are the highlights of this release:
 - Define sets of dependencies that work together with Java Platform plugin
 - New C++ plugins with dependency management built-in
 - New C++ project types for gradle init
 - Service injection into plugins and project extensions

For more details see <https://docs.gradle.org/5.2.1/release-notes.html>

> Task :hoplite-aws:signMavenJavaPublication FAILED

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':hoplite-aws:signMavenJavaPublication'.
> No value has been specified for property 'signatory.keyId'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at <https://help.gradle.org>
s
add signatory.keyId=xx to the gradle.properties file
and it will work
can you PR that too when you do it ?
b
yeah
s
Thank you
b
now i get
Copy code
> Task :hoplite-core:compileKotlin
w: /Users/bbaldino/work/hoplite/hoplite-core/src/main/kotlin/com/sksamuel/hoplite/preprocessor/PropsPreprocessor.kt: (29, 73): The resulting type of this 'javaClass' call is Class<PropsPreprocessor.Companion> and not Class<PropsPreprocessor>. Please use the more clear '::class.java' syntax to avoid confusion
s
that’s just a warning so you can either fix it as part of your PR or ignore it
b
ah, oops, error was further down
hm, still complaining about signatory i guess:
Copy code
* What went wrong:
A problem was found with the configuration of task ':hoplite-aws:signMavenJavaPublication'.
> No value has been specified for property 'signatory.keyId'.
this is from running 
./gradlew publishToMavenLocal
s
But you added signatory.keyId to gradle.properties ?
b
yeah
Copy code
cat gradle.properties
#these should be overriden if you want to do release
signing.keyId=xx
signatory.keyId=xx
signing.password=xx
signing.secretKeyRingFile=~/sksamuel.gpg

ossrhUsername=xx
ossrhPassword=xx

intellijPublishUsername=xx
intellijPublishPassword=xx

org.gradle.caching=true
sandbox = .
s
ok gonna try from fresh
its running
same thing
I’ll have to fix tonight, I don’t know what’s causing it
b
ok
s
it’s basically a property that the plugin needs
and setting dummy values in the gradle.properties usually works
it shouldn’t need to sign them for local anyway
b
worked around it by hard-coding 
ext.isReleaseVersion
to false
s
ah ok
b
i didn't include any of the gradle changes
5 Views
Open in Slack
PreviousNext
Powered by