we have a gradle plugin that generates protos for both kotlin and java and i'm hitting an interestin...

# gradle

[jrod]

we have a gradle plugin that generates protos for both kotlin and java and i'm hitting an interesting bug where kotlin projects consume java protos.

the compileKotlin task isn't able to find the java generated sources.

val compileKotlinTask = project.tasks.named("compileKotlin") as TaskProvider<KotlinCompile>
        compileKotlinTask.configure {
          it.source(javaOutDirs)  // javaOutDirs is where the java protos are generated
          it.dependsOn(wireTask)
        }

but my gradle output shows:

14:56:58.695 [DEBUG] [org.gradle.api.Task] [KOTLIN] all kotlin sources: src/main/java/com/squareup/dinosaurs/Sample.kt
14:56:58.695 [DEBUG] [org.gradle.api.Task] [KOTLIN] compileKotlin source roots: [
	/...src/test/projects/kotlin-project-java-protos/src/main/java/com/squareup/dinosaurs/Sample.kt]
14:56:58.695 [DEBUG] [org.gradle.api.Task] [KOTLIN] compileKotlin java source roots: [
// why empty?!
	]

[tapchicoma]

Hm, doesn't setSource() should set only kotlin sources?

[tapchicoma]

interestingly that setSource() overloads has different behaviour:

// override setSource to track source directory sets and files (for generated android folders)
    override fun setSource(sources: Any?) {
        sourceRootsContainer.set(sources)
        super.setSource(sources)
    }

    // override source to track source directory sets and files (for generated android folders)
    override fun source(vararg sources: Any?): SourceTask? {
        sourceRootsContainer.add(*sources)
        return super.source(*sources)
    }

[tapchicoma]

where sourceRootsContainer.set(sources) clears already existing roots

[tapchicoma]

though such behaviour aligns with SourceTask

[jrod]

correct, but i'm calling source() instead of setSource(), so it should append to the list, right?

[jrod]

or if that's meant for kotlin sources only, is there a way to pass java sources? or will i have to invoke another javac pass for the protos themselves (not ideal...)?

[tapchicoma]

yeah, you are right - it should append

[tapchicoma]

or if that's meant for kotlin sources only, is there a way to pass java sources? or will i have to invoke another javac pass for the protos themselves (not ideal...)?

I would expect that this class only takes Kotlin sources via PatternFilterable interface

[tapchicoma]

not the best way, but I can think of generating jar out of java classes and adding it as classpath to KotlinCompile tasks

[tapchicoma]

also check if wire task runs actualy before Kotlin compile by running:

./gradlew -m generateProtos

[tapchicoma]

and possibly related thread: https://discuss.gradle.org/t/kotlin-groovy-and-java-compilation/14903/9

[jrod]

yup, confirmed that before:

:generateProtos SKIPPED
:compileKotlin SKIPPED
:compileJava SKIPPED

[jrod]

ooh that thread is interesting, let me take a look

[jrod]

so i was able to reverse the order, but i'm still getting the same error 🤔

[jrod]

ok, found the issue after a bit more digging: https://youtrack.jetbrains.com/issue/KT-12715

[tapchicoma]

I think, in general, usage of afterEvaluate { .. } is deprecated

[tapchicoma]

as it leads to such kind of problems

[jrod]

right, i'm trying to figure out a way around this. ideally, the kotlin plugin authors would move to using lazy eval and/or a live collection

[jrod]

funny enough, i think i came across a github issue showing similar behavior with your handle on it 🙂

[jrod]

https://github.com/JLLeitschuh/ktlint-gradle/issues/153